Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/src/mediawiki.Title/Title.js

Summary

Maintainability
D
2 days
Test Coverage

File Title.js has 414 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * @author Neil Kandalgaonkar, 2010
 * @since 1.18
 */
Severity: Minor
Found in resources/src/mediawiki.Title/Title.js - About 5 hrs to fix

    Function parse has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        parse = function ( title, defaultNamespace ) {
        let namespace = defaultNamespace === undefined ? NS_MAIN : defaultNamespace;

        title = title
            // Strip Unicode bidi override characters
    Severity: Minor
    Found in resources/src/mediawiki.Title/Title.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parse has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        parse = function ( title, defaultNamespace ) {
        let namespace = defaultNamespace === undefined ? NS_MAIN : defaultNamespace;

        title = title
            // Strip Unicode bidi override characters
    Severity: Major
    Found in resources/src/mediawiki.Title/Title.js - About 3 hrs to fix

      Function newFromUserInput has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      Title.newFromUserInput = function ( title, defaultNamespace, options ) {
    let namespace = parseInt( defaultNamespace ) || NS_MAIN;

    // merge options into defaults
    options = $.extend( {
      Severity: Minor
      Found in resources/src/mediawiki.Title/Title.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

              if (
            title.indexOf( '.' ) !== -1 && (
                title === '.' || title === '..' ||
                title.indexOf( './' ) === 0 ||
                title.indexOf( '../' ) === 0 ||
      Severity: Critical
      Found in resources/src/mediawiki.Title/Title.js - About 1 hr to fix

        Function newFromUserInput has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Title.newFromUserInput = function ( title, defaultNamespace, options ) {
    let namespace = parseInt( defaultNamespace ) || NS_MAIN;

    // merge options into defaults
    options = $.extend( {
        Severity: Minor
        Found in resources/src/mediawiki.Title/Title.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                      return false;
          Severity: Major
          Found in resources/src/mediawiki.Title/Title.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return false;
            Severity: Major
            Found in resources/src/mediawiki.Title/Title.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return false;
              Severity: Major
              Found in resources/src/mediawiki.Title/Title.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return false;
                Severity: Major
                Found in resources/src/mediawiki.Title/Title.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return {
            namespace: namespace,
            title: title,
            fragment: fragment
        };
                  Severity: Major
                  Found in resources/src/mediawiki.Title/Title.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return false;
                    Severity: Major
                    Found in resources/src/mediawiki.Title/Title.js - About 30 mins to fix

                      Function sanitize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          sanitize = function ( s, filter ) {
        const rules = sanitationRules;

        for ( let i = 0, ruleLength = rules.length; i < ruleLength; ++i ) {
            const rule = rules[ i ];
                      Severity: Minor
                      Found in resources/src/mediawiki.Title/Title.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if ( title !== '' && title[ 0 ] === ':' ) {
        // Initial colon means main namespace instead of specified default
        namespace = NS_MAIN;
        title = title
            // Strip colon
                      Severity: Minor
                      Found in resources/src/mediawiki.Title/Title.js and 1 other location - About 30 mins to fix
                      resources/src/mediawiki.Title/Title.js on lines 236..244

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 45.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if ( title !== '' && title[ 0 ] === ':' ) {
            // Initial colon means main namespace instead of specified default
            namespace = NS_MAIN;
            title = title
                // Strip colon
                      Severity: Minor
                      Found in resources/src/mediawiki.Title/Title.js and 1 other location - About 30 mins to fix
                      resources/src/mediawiki.Title/Title.js on lines 539..547

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 45.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status