wikimedia/mediawiki-core

View on GitHub
resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js

Summary

Maintainability
D
3 days
Test Coverage

File BookletLayout.js has 361 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* global moment */
( function () {

    /**
     * @classdesc Encapsulates the process of uploading a file
Severity: Minor
Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js - About 4 hrs to fix

    Function getErrorMessageForStateDetails has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        mw.Upload.BookletLayout.prototype.getErrorMessageForStateDetails = function () {
            var state = this.upload.getState(),
                stateDetails = this.upload.getStateDetails(),
                warnings = stateDetails.upload && stateDetails.upload.warnings,
                $ul = $( '<ul>' ),
    Severity: Major
    Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js - About 2 hrs to fix

      Function renderInfoForm has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          mw.Upload.BookletLayout.prototype.renderInfoForm = function () {
              var fieldset;
      
              this.filePreview = new OO.ui.Widget( {
                  classes: [ 'mw-upload-bookletLayout-filePreview' ]
      Severity: Minor
      Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js - About 1 hr to fix

        Function uploadFile has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            mw.Upload.BookletLayout.prototype.uploadFile = function () {
                var deferred = $.Deferred(),
                    startTime = mw.now(),
                    layout = this,
                    file = this.getFile();
        Severity: Minor
        Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js - About 1 hr to fix

          Function initialize has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              mw.Upload.BookletLayout.prototype.initialize = function () {
                  var booklet = this;
          
                  this.clear();
                  this.upload = this.createUpload();
          Severity: Minor
          Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js - About 1 hr to fix

            Function BookletLayout has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                mw.Upload.BookletLayout = function ( config ) {
                    // Parent constructor
                    mw.Upload.BookletLayout.super.call( this, config );
            
                    this.$overlay = config.$overlay;
            Severity: Minor
            Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js - About 1 hr to fix

              Avoid too many return statements within this function.
              Open

                              return $.Deferred().resolve( new OO.ui.Error(
                                  $( '<p>' ).msg( 'filename-bad-prefix', warnings[ 'bad-prefix' ] ),
                                  { recoverable: false }
                              ) );
              Severity: Major
              Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return $.Deferred().resolve( new OO.ui.Error(
                                    $( '<p>' ).msg( 'file-deleted-duplicate', 'File:' + warnings[ 'duplicate-archive' ] ),
                                    { recoverable: false }
                                ) );
                Severity: Major
                Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return $.Deferred().resolve( new OO.ui.Error(
                                      $( '<p>' ).msg( 'file-exists-duplicate', warnings.duplicate.length ).append( $ul ),
                                      { recoverable: false }
                                  ) );
                  Severity: Major
                  Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return $.Deferred().resolve( new OO.ui.Error(
                                        $( '<p>' ).msg( 'filewasdeleted', 'File:' + warnings[ 'was-deleted' ] ),
                                        { recoverable: false }
                                    ) );
                    Severity: Major
                    Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return $.Deferred().resolve( new OO.ui.Error(
                                          $( '<p>' ).msg( 'badfilename', warnings.badfilename )
                                      ) );
                      Severity: Major
                      Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                        return $.Deferred().resolve( new OO.ui.Error(
                                            // Let's get all the help we can if we can't pin point the error
                                            $( '<p>' ).msg( 'api-error-unknown-warning', JSON.stringify( stateDetails ) ),
                                            { recoverable: false }
                                        ) );
                        Severity: Major
                        Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                          return $.Deferred().resolve( new OO.ui.Error(
                                              $( '<p>' ).msg( 'filename-thumb-name' ),
                                              { recoverable: false }
                                          ) );
                          Severity: Major
                          Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js - About 30 mins to fix

                            Similar blocks of code found in 4 locations. Consider refactoring.
                            Open

                                        } else if ( warnings[ 'exists-normalized' ] !== undefined ) {
                                            return $.Deferred().resolve( new OO.ui.Error(
                                                $( '<p>' ).msg( 'fileexists', 'File:' + warnings[ 'exists-normalized' ] ),
                                                { recoverable: false }
                                            ) );
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 377..428
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 405..428
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 410..428

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 62.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 4 locations. Consider refactoring.
                            Open

                                        } else if ( warnings[ 'duplicate-archive' ] !== undefined ) {
                                            return $.Deferred().resolve( new OO.ui.Error(
                                                $( '<p>' ).msg( 'file-deleted-duplicate', 'File:' + warnings[ 'duplicate-archive' ] ),
                                                { recoverable: false }
                                            ) );
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 372..428
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 377..428
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 410..428

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 62.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 4 locations. Consider refactoring.
                            Open

                                        } else if ( warnings[ 'page-exists' ] !== undefined ) {
                                            return $.Deferred().resolve( new OO.ui.Error(
                                                $( '<p>' ).msg( 'filepageexists', 'File:' + warnings[ 'page-exists' ] ),
                                                { recoverable: false }
                                            ) );
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 372..428
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 405..428
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 410..428

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 62.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 4 locations. Consider refactoring.
                            Open

                                        } else if ( warnings[ 'was-deleted' ] !== undefined ) {
                                            return $.Deferred().resolve( new OO.ui.Error(
                                                $( '<p>' ).msg( 'filewasdeleted', 'File:' + warnings[ 'was-deleted' ] ),
                                                { recoverable: false }
                                            ) );
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 372..428
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 377..428
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 405..428

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 62.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        new OO.ui.FieldLayout( this.descriptionWidget, {
                                            label: mw.msg( 'upload-form-label-infoform-description' ),
                                            align: 'top',
                                            help: mw.msg( 'upload-form-label-infoform-description-tooltip' )
                                        } )
                            Severity: Minor
                            Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js and 1 other location - About 45 mins to fix
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 544..548

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 50.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        new OO.ui.FieldLayout( this.filenameWidget, {
                                            label: mw.msg( 'upload-form-label-infoform-name' ),
                                            align: 'top',
                                            help: mw.msg( 'upload-form-label-infoform-name-tooltip' )
                                        } ),
                            Severity: Minor
                            Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js and 1 other location - About 45 mins to fix
                            resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js on lines 549..553

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 50.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                mw.Upload.BookletLayout.prototype.getText = function () {
                                    return this.descriptionWidget.getValue();
                                };
                            Severity: Minor
                            Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js and 1 other location - About 35 mins to fix
                            resources/lib/ooui/oojs-ui-windows.js on lines 93..95

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 47.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    this.on( 'fileUploadProgress', function ( progress ) {
                                        this.progressBarWidget.setProgress( progress * 100 );
                                    }.bind( this ) );
                            Severity: Minor
                            Found in resources/src/mediawiki.Upload.BookletLayout/BookletLayout.js and 1 other location - About 30 mins to fix
                            resources/src/mediawiki.ForeignStructuredUpload.BookletLayout/BookletLayout.js on lines 306..308

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 45.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status