Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/src/mediawiki.editRecovery/edit.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function onLoadHandler has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function onLoadHandler( $editForm ) {
    mw.hook( 'wikipage.editform' ).remove( onLoadHandler );

    // Monitor all text-entry inputs for changes/typing.
    const inputsToMonitorSelector = 'textarea, select, input:not([type="hidden"], [type="submit"])';
Severity: Major
Found in resources/src/mediawiki.editRecovery/edit.js - About 2 hrs to fix

    Function onLoadData has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function onLoadData( pageData ) {
    if ( wasPosted ) {
        // If this is a POST request, save the current data (e.g. from a preview).
        saveFormData();
    }
    Severity: Minor
    Found in resources/src/mediawiki.editRecovery/edit.js - About 1 hr to fix

      Function isSameAsOriginal has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function isSameAsOriginal( pageData, ignoreRevIds = false ) {
    for ( const fieldName in inputFields ) {
        if ( ignoreRevIds && ( fieldName === 'editRevId' || fieldName === 'parentRevId' ) ) {
            continue;
        }
      Severity: Minor
      Found in resources/src/mediawiki.editRecovery/edit.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status