Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/src/mediawiki.feedback/FeedbackDialog.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function initialize has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

FeedbackDialog.prototype.initialize = function () {
    let feedbackSubjectFieldLayout, feedbackMessageFieldLayout,
        feedbackFieldsetLayout, termsOfUseLabel;

    // Parent method
Severity: Minor
Found in resources/src/mediawiki.feedback/FeedbackDialog.js - About 1 hr to fix

    Function getSetupProcess has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    FeedbackDialog.prototype.getSetupProcess = function ( data ) {
    return FeedbackDialog.super.prototype.getSetupProcess.call( this, data )
        .next( function () {
            // Get the URL of the target page, we want to use that in links in the intro
            // and in the success dialog
    Severity: Minor
    Found in resources/src/mediawiki.feedback/FeedbackDialog.js - About 1 hr to fix

      Function getActionProcess has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      FeedbackDialog.prototype.getActionProcess = function ( action ) {
    if ( action === 'cancel' ) {
        return new OO.ui.Process( function () {
            this.close( { action: action } );
        }, this );
      Severity: Minor
      Found in resources/src/mediawiki.feedback/FeedbackDialog.js - About 1 hr to fix

        Function getActionProcess has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        FeedbackDialog.prototype.getActionProcess = function ( action ) {
    if ( action === 'cancel' ) {
        return new OO.ui.Process( function () {
            this.close( { action: action } );
        }, this );
        Severity: Minor
        Found in resources/src/mediawiki.feedback/FeedbackDialog.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status