Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/src/mediawiki.page.gallery.slideshow.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function drawCarousel has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    mw.GallerySlideshow.prototype.drawCarousel = function () {
        var nextButton, prevButton, toggleButton, interfaceElements, carouselStack;

        this.$carousel = $( '<li>' ).addClass( 'gallerycarousel' );
Severity: Minor
Found in resources/src/mediawiki.page.gallery.slideshow.js - About 1 hr to fix

    Function showCurrentImage has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        mw.GallerySlideshow.prototype.showCurrentImage = function ( init ) {
        var $thumbnail, $imgLink,
            $imageLi = this.getCurrentImage(),
            $caption = $imageLi.find( '.gallerytext' );
    Severity: Minor
    Found in resources/src/mediawiki.page.gallery.slideshow.js - About 1 hr to fix

      Function getImageInfo has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          mw.GallerySlideshow.prototype.getImageInfo = function ( $img ) {
        var api, title, params,
            imageSrc = $img.attr( 'src' );

        // Reject promise if there is no thumbnail image
      Severity: Minor
      Found in resources/src/mediawiki.page.gallery.slideshow.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            mw.GallerySlideshow.prototype.nextImage = function () {
        this.$currentImage = this.getNextImage();
        this.showCurrentImage();
    };
        Severity: Minor
        Found in resources/src/mediawiki.page.gallery.slideshow.js and 1 other location - About 50 mins to fix
        resources/src/mediawiki.page.gallery.slideshow.js on lines 484..487

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            mw.GallerySlideshow.prototype.prevImage = function () {
        this.$currentImage = this.getPrevImage();
        this.showCurrentImage();
    };
        Severity: Minor
        Found in resources/src/mediawiki.page.gallery.slideshow.js and 1 other location - About 50 mins to fix
        resources/src/mediawiki.page.gallery.slideshow.js on lines 475..478

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status