Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/src/mediawiki.rcfilters/Controller.js

Summary

Maintainability
F
5 days
Test Coverage

File Controller.js has 699 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var byteLength = require( 'mediawiki.String' ).byteLength,
    UriProcessor = require( './UriProcessor.js' ),
    Controller;

/* eslint no-underscore-dangle: "off" */
Severity: Major
Found in resources/src/mediawiki.rcfilters/Controller.js - About 1 day to fix

    Function initialize has 218 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Controller.prototype.initialize = function ( filterStructure, namespaceStructure, tagList, conditionalViews ) {
    var parsedSavedQueries, pieces,
        nsAllContents, nsAllDiscussions,
        displayConfig = mw.config.get( 'StructuredChangeFiltersDisplayConfig' ),
        defaultSavedQueryExists = mw.config.get( 'wgStructuredChangeFiltersDefaultSavedQueryExists' ),
    Severity: Major
    Found in resources/src/mediawiki.rcfilters/Controller.js - About 1 day to fix

      Function initialize has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

      Controller.prototype.initialize = function ( filterStructure, namespaceStructure, tagList, conditionalViews ) {
    var parsedSavedQueries, pieces,
        nsAllContents, nsAllDiscussions,
        displayConfig = mw.config.get( 'StructuredChangeFiltersDisplayConfig' ),
        defaultSavedQueryExists = mw.config.get( 'wgStructuredChangeFiltersDefaultSavedQueryExists' ),
      Severity: Minor
      Found in resources/src/mediawiki.rcfilters/Controller.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function addNumberValuesToGroup has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Controller.prototype.addNumberValuesToGroup = function ( groupData, arbitraryValues ) {
    var controller = this,
        normalizeWithinRange = function ( range, val ) {
            if ( val < range.min ) {
                return range.min; // Min
      Severity: Minor
      Found in resources/src/mediawiki.rcfilters/Controller.js - About 1 hr to fix

        Function _queryChangesList has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Controller.prototype._queryChangesList = function ( counterId, params ) {
    var uri = this.uriProcessor.getUpdatedUri(),
        stickyParams = this.filtersModel.getStickyParamsValues(),
        requestId,
        latestRequest;
        Severity: Minor
        Found in resources/src/mediawiki.rcfilters/Controller.js - About 1 hr to fix

          Function _doLiveUpdate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

          Controller.prototype._doLiveUpdate = function () {
    if ( !this._shouldCheckForNewChanges() ) {
        // skip this turn and check back later
        this._scheduleLiveUpdate();
        return;
          Severity: Minor
          Found in resources/src/mediawiki.rcfilters/Controller.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function updateChangesList has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          Controller.prototype.updateChangesList = function ( params, updateMode ) {
    updateMode = updateMode === undefined ? this.FILTER_CHANGE : updateMode;

    if ( updateMode === this.FILTER_CHANGE ) {
        this.uriProcessor.updateURL( params );
          Severity: Minor
          Found in resources/src/mediawiki.rcfilters/Controller.js - About 1 hr to fix

            Function _extractChangesListInfo has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            Controller.prototype._extractChangesListInfo = function ( $root, statusCode ) {
    var info,
        $changesListContents = $root.find( '.mw-changeslist' ).first().contents(),
        areResults = !!$changesListContents.length,
        checkForLogout = !areResults && statusCode === 200;
            Severity: Minor
            Found in resources/src/mediawiki.rcfilters/Controller.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function addNumberValuesToGroup has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            Controller.prototype.addNumberValuesToGroup = function ( groupData, arbitraryValues ) {
    var controller = this,
        normalizeWithinRange = function ( range, val ) {
            if ( val < range.min ) {
                return range.min; // Min
            Severity: Minor
            Found in resources/src/mediawiki.rcfilters/Controller.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            Controller.prototype.toggleInvertedTags = function () {
    this.filtersModel.toggleInvertedTags();

    if (
        this.filtersModel.getFiltersByView( 'tags' ).filter(
            Severity: Major
            Found in resources/src/mediawiki.rcfilters/Controller.js and 1 other location - About 4 hrs to fix
            resources/src/mediawiki.rcfilters/Controller.js on lines 594..609

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            Controller.prototype.toggleInvertedNamespaces = function () {
    this.filtersModel.toggleInvertedNamespaces();

    if (
        this.filtersModel.getFiltersByView( 'namespaces' ).filter(
            Severity: Major
            Found in resources/src/mediawiki.rcfilters/Controller.js and 1 other location - About 4 hrs to fix
            resources/src/mediawiki.rcfilters/Controller.js on lines 574..589

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            Controller.prototype.setDefaultSavedQuery = function ( queryID ) {
    this.savedQueriesModel.setDefault( queryID );
    this._saveSavedQueries();
};
            Severity: Minor
            Found in resources/src/mediawiki.rcfilters/Controller.js and 1 other location - About 45 mins to fix
            resources/src/mediawiki.rcfilters/Controller.js on lines 793..797

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            Controller.prototype.removeSavedQuery = function ( queryID ) {
    this.savedQueriesModel.removeQuery( queryID );

    this._saveSavedQueries();
};
            Severity: Minor
            Found in resources/src/mediawiki.rcfilters/Controller.js and 1 other location - About 45 mins to fix
            resources/src/mediawiki.rcfilters/Controller.js on lines 820..823

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                nsAllDiscussions = {
        name: 'all-discussions',
        label: mw.msg( 'rcfilters-alldiscussions-label' ),
        description: '',
        identifiers: [ 'talk' ],
            Severity: Minor
            Found in resources/src/mediawiki.rcfilters/Controller.js and 1 other location - About 40 mins to fix
            resources/src/mediawiki.rcfilters/Controller.js on lines 72..79

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                nsAllContents = {
        name: 'all-contents',
        label: mw.msg( 'rcfilters-allcontents-label' ),
        description: '',
        identifiers: [ 'subject' ],
            Severity: Minor
            Found in resources/src/mediawiki.rcfilters/Controller.js and 1 other location - About 40 mins to fix
            resources/src/mediawiki.rcfilters/Controller.js on lines 80..87

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if ( this.applyParamChange( params ) ) {
        // Only update the changes list if there was a change to actual filters
        this.updateChangesList();
    } else {
        this.uriProcessor.updateURL( params );
            Severity: Minor
            Found in resources/src/mediawiki.rcfilters/Controller.js and 1 other location - About 35 mins to fix
            resources/src/mediawiki.rcfilters/Controller.js on lines 845..850

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if ( this.applyParamChange( params ) ) {
        // Update changes list only if there was a difference in filter selection
        this.updateChangesList();
    } else {
        this.uriProcessor.updateURL( params );
            Severity: Minor
            Found in resources/src/mediawiki.rcfilters/Controller.js and 1 other location - About 35 mins to fix
            resources/src/mediawiki.rcfilters/Controller.js on lines 473..478

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status