Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/src/mediawiki.rcfilters/ui/ChangesListWrapperWidget.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function onModelUpdate has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ChangesListWrapperWidget.prototype.onModelUpdate = function (
    $changesListContent, $fieldset, noResultsDetails, isInitialDOM, from
) {
    var conflictItem,
        $message = $( '<div>' )
Severity: Major
Found in resources/src/mediawiki.rcfilters/ui/ChangesListWrapperWidget.js - About 2 hrs to fix

    Function onModelUpdate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    ChangesListWrapperWidget.prototype.onModelUpdate = function (
    $changesListContent, $fieldset, noResultsDetails, isInitialDOM, from
) {
    var conflictItem,
        $message = $( '<div>' )
    Severity: Minor
    Found in resources/src/mediawiki.rcfilters/ui/ChangesListWrapperWidget.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function applyHighlight has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ChangesListWrapperWidget.prototype.applyHighlight = function () {
    if ( !this.filtersViewModel.isHighlightEnabled() ) {
        return;
    }
    Severity: Minor
    Found in resources/src/mediawiki.rcfilters/ui/ChangesListWrapperWidget.js - About 1 hr to fix

      Function emphasizeNewChanges has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      ChangesListWrapperWidget.prototype.emphasizeNewChanges = function ( from ) {
    var $firstNew,
        $indicator,
        $newChanges = $( [] ),
        selector = this.inEnhancedMode() ?
      Severity: Minor
      Found in resources/src/mediawiki.rcfilters/ui/ChangesListWrapperWidget.js - About 1 hr to fix

        Function ChangesListWrapperWidget has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            filtersViewModel,
    changesListViewModel,
    controller,
    $changesListRoot,
    config
        Severity: Minor
        Found in resources/src/mediawiki.rcfilters/ui/ChangesListWrapperWidget.js - About 35 mins to fix

          Function onModelUpdate has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              $changesListContent, $fieldset, noResultsDetails, isInitialDOM, from
          Severity: Minor
          Found in resources/src/mediawiki.rcfilters/ui/ChangesListWrapperWidget.js - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status