Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/src/mediawiki.rcfilters/ui/FormWrapperWidget.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function cleanUpFieldset has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

FormWrapperWidget.prototype.cleanUpFieldset = function () {
    this.$element.find( '.clshowhideoption[data-feature-in-structured-ui=1]' ).each( function () {
        // HACK: Remove the text node after the span.
        // If there isn't one, we're at the end, so remove the text node before the span.
        // This would be unnecessary if we added separators with CSS.
Severity: Minor
Found in resources/src/mediawiki.rcfilters/ui/FormWrapperWidget.js - About 1 hr to fix

    Function cleanUpFieldset has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    FormWrapperWidget.prototype.cleanUpFieldset = function () {
    this.$element.find( '.clshowhideoption[data-feature-in-structured-ui=1]' ).each( function () {
        // HACK: Remove the text node after the span.
        // If there isn't one, we're at the end, so remove the text node before the span.
        // This would be unnecessary if we added separators with CSS.
    Severity: Minor
    Found in resources/src/mediawiki.rcfilters/ui/FormWrapperWidget.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function FormWrapperWidget has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    var FormWrapperWidget = function MwRcfiltersUiFormWrapperWidget( filtersModel, changeListModel, controller, $formRoot, config ) {
    Severity: Minor
    Found in resources/src/mediawiki.rcfilters/ui/FormWrapperWidget.js - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status