wikimedia/mediawiki-core

View on GitHub
resources/src/mediawiki.rcfilters/ui/MenuSelectWidget.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function MwRcfiltersUiMenuSelectWidget has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MenuSelectWidget = function MwRcfiltersUiMenuSelectWidget( controller, model, config ) {
    var header;

    config = config || {};

Severity: Major
Found in resources/src/mediawiki.rcfilters/ui/MenuSelectWidget.js - About 2 hrs to fix

    Function lazyMenuCreation has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    MenuSelectWidget.prototype.lazyMenuCreation = function () {
        var widget = this,
            items = [],
            viewGroupCount = {},
            groups = this.model.getFilterGroups();
    Severity: Major
    Found in resources/src/mediawiki.rcfilters/ui/MenuSelectWidget.js - About 2 hrs to fix

      Function postProcessItems has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      MenuSelectWidget.prototype.postProcessItems = function () {
          var i,
              itemWasSelected = false,
              items = this.getItems();
      
      
      Severity: Minor
      Found in resources/src/mediawiki.rcfilters/ui/MenuSelectWidget.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function onDocumentKeyDown has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      MenuSelectWidget.prototype.onDocumentKeyDown = function ( e ) {
          var nextItem,
              currentItem = this.findHighlightedItem() || this.findSelectedItem();
      
          // Call parent
      Severity: Minor
      Found in resources/src/mediawiki.rcfilters/ui/MenuSelectWidget.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function MwRcfiltersUiMenuSelectWidget has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      MenuSelectWidget = function MwRcfiltersUiMenuSelectWidget( controller, model, config ) {
          var header;
      
          config = config || {};
      
      
      Severity: Minor
      Found in resources/src/mediawiki.rcfilters/ui/MenuSelectWidget.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status