Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/src/mediawiki.searchSuggest/searchSuggest.js

Summary

Maintainability
C
1 day
Test Coverage

File searchSuggest.js has 281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * Add search suggestions to the search form.
 */
( function () {
    // eslint-disable-next-line no-jquery/no-map-util
Severity: Minor
Found in resources/src/mediawiki.searchSuggest/searchSuggest.js - About 2 hrs to fix

    Function specialRenderFunction has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function specialRenderFunction( query, context ) {
            var $el = this,
                formData = getFormData( context );

            // linkParams object is modified and reused
    Severity: Minor
    Found in resources/src/mediawiki.searchSuggest/searchSuggest.js - About 1 hr to fix

      Function onAfterUpdate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function onAfterUpdate( metadata ) {
            var context = this.data( 'suggestionsContext' );

            mw.track( 'mediawiki.searchSuggest', {
                action: 'impression-results',
      Severity: Minor
      Found in resources/src/mediawiki.searchSuggest/searchSuggest.js - About 1 hr to fix

        Function request has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                request: function ( api, query, response, limit, namespace ) {
        Severity: Minor
        Found in resources/src/mediawiki.searchSuggest/searchSuggest.js - About 35 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          cancel: function () {
                    var node = this[ 0 ],
                        request = $.data( node, 'request' );

                    if ( request ) {
          Severity: Major
          Found in resources/src/mediawiki.searchSuggest/searchSuggest.js and 1 other location - About 1 hr to fix
          resources/src/mediawiki.userSuggest.js on lines 26..34

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 64.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          mw.track( 'mediawiki.searchSuggest', {
                    action: 'click-result',
                    numberOfResults: context.config.suggestions.length,
                    index: context.config.suggestions.indexOf( text )
                } );
          Severity: Major
          Found in resources/src/mediawiki.searchSuggest/searchSuggest.js and 1 other location - About 1 hr to fix
          resources/src/mediawiki.searchSuggest/searchSuggest.js on lines 412..416

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                                  mw.track( 'mediawiki.searchSuggest', {
                            action: 'click-result',
                            numberOfResults: context.config.suggestions.length,
                            index: context.config.suggestions.indexOf( text )
                        } );
          Severity: Major
          Found in resources/src/mediawiki.searchSuggest/searchSuggest.js and 1 other location - About 1 hr to fix
          resources/src/mediawiki.searchSuggest/searchSuggest.js on lines 274..278

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status