Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js

Summary

Maintainability
D
1 day
Test Coverage

Function MwWidgetsRowWidget has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

mw.widgets.RowWidget = function MwWidgetsRowWidget( config ) {
    config = config || {};

    // Parent constructor
    mw.widgets.RowWidget.super.call( this, config );
Severity: Minor
Found in resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    mw.widgets.RowWidget.prototype.removeItems = function ( items ) {
    var i, len, cells;

    OO.ui.mixin.GroupElement.prototype.removeItems.call( this, items );
    Severity: Major
    Found in resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js and 1 other location - About 5 hrs to fix
    resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 301..310

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 137.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    mw.widgets.RowWidget.prototype.addItems = function ( items, index ) {
    var i, len;

    OO.ui.mixin.GroupElement.prototype.addItems.call( this, items, index );
    Severity: Major
    Found in resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js and 1 other location - About 4 hrs to fix
    resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 287..295

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    mw.widgets.RowWidget.prototype.setIndex = function ( index ) {
    this.model.setIndex( index );
};
    Severity: Major
    Found in resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js and 4 other locations - About 40 mins to fix
    resources/lib/ooui/oojs-ui-core.js on lines 10846..10848
    resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 226..228
    resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 227..229
    resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 237..239

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    mw.widgets.RowWidget.prototype.removeCell = function ( index ) {
    this.model.removeCell( index );
};
    Severity: Major
    Found in resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js and 4 other locations - About 40 mins to fix
    resources/lib/ooui/oojs-ui-core.js on lines 10846..10848
    resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 163..165
    resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 227..229
    resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 237..239

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    mw.widgets.RowWidget.prototype.insertCell = function ( data, index, key ) {
    this.model.insertCell( data, index, key );
};
    Severity: Minor
    Found in resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js and 1 other location - About 35 mins to fix
    resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 170..172

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    mw.widgets.RowWidget.prototype.clear = function () {
    this.model.clear();
};
    Severity: Major
    Found in resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js and 5 other locations - About 35 mins to fix
    resources/lib/ooui/oojs-ui-core.js on lines 9571..9573
    resources/lib/ooui/oojs-ui-core.js on lines 12958..12960
    resources/lib/ooui/oojs-ui-widgets.js on lines 3983..3985
    resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 244..246
    resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 251..253

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if ( this.model.getRowProperties().isDeletable ) {
        this.deleteButton.connect( this, {
            click: 'onDeleteButtonClick'
        } );
    }
    Severity: Minor
    Found in resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js and 1 other location - About 35 mins to fix
    resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 100..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        if ( this.model.getRowProperties().isDeletable ) {
        this.$element.append( this.deleteButton.$element );
    }
    Severity: Minor
    Found in resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js and 2 other locations - About 30 mins to fix
    resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 109..111
    resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 113..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status