wikimedia/mediawiki-core

View on GitHub
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js

Summary

Maintainability
F
3 days
Test Coverage

Function MwWidgetsTableWidget has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

mw.widgets.TableWidget = function MwWidgetsTableWidget( config ) {
    var headerRowItems = [],
        insertionRowItems = [],
        columnProps, prop, i, len;

Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js - About 3 hrs to fix

    File mw.widgets.TableWidget.js has 293 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * @classdesc Groups {@link mw.widgets.RowWidget row widgets} together to form a bidimensional
     * grid of text inputs.
     *
     * @class
    Severity: Minor
    Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js - About 3 hrs to fix

      Function MwWidgetsTableWidget has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      mw.widgets.TableWidget = function MwWidgetsTableWidget( config ) {
          var headerRowItems = [],
              insertionRowItems = [],
              columnProps, prop, i, len;
      
      
      Severity: Minor
      Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function onInsertionRowInputChange has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      mw.widgets.TableWidget.prototype.onInsertionRowInputChange = function ( colIndex, value ) {
          var insertionRowItems = this.insertionRow.getItems(),
              newRowData = [],
              i, len, lastRow;
      
      
      Severity: Minor
      Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function refreshTableMarginals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      mw.widgets.TableWidget.prototype.refreshTableMarginals = function () {
          var tableProps = this.model.getTableProperties(),
              columnProps = this.model.getAllColumnProperties(),
              rowItems,
              i, len, prop;
      Severity: Minor
      Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      mw.widgets.TableWidget.prototype.removeItems = function ( items ) {
          var i, len, rows;
      
          OO.ui.mixin.GroupElement.prototype.removeItems.call( this, items );
      
      
      resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 138..147

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      mw.widgets.TableWidget.prototype.addItems = function ( items, index ) {
          var i, len;
      
          OO.ui.mixin.GroupElement.prototype.addItems.call( this, items, index );
      
      
      resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 124..132

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 117.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              for ( i = 0, len = columnProps.length; i < len; i++ ) {
                  prop = columnProps[ i ];
                  rowItems.push(
                      this.getHeaderRowItem( prop.label, prop.key, prop.index )
                  );
      resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 48..53

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              for ( i = 0, len = columnProps.length; i < len; i++ ) {
                  prop = columnProps[ i ];
                  headerRowItems.push(
                      this.getHeaderRowItem( prop.label, prop.key, prop.index )
                  );
      resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 574..579

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      mw.widgets.TableWidget.prototype.insertColumn = function ( data, index, key, label ) {
          this.model.insertColumn( data, index, key, label );
      };
      Severity: Minor
      Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js and 1 other location - About 55 mins to fix
      resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 201..203

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      mw.widgets.TableWidget.prototype.insertRow = function ( data, index, key, label ) {
          this.model.insertRow( data, index, key, label );
      };
      Severity: Minor
      Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js and 1 other location - About 55 mins to fix
      resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 217..219

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      mw.widgets.TableWidget.prototype.removeColumn = function ( key ) {
          this.model.removeColumn( key );
      };
      resources/lib/ooui/oojs-ui-core.js on lines 10846..10848
      resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 163..165
      resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 226..228
      resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 227..229

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      mw.widgets.TableWidget.prototype.removeRow = function ( key ) {
          this.model.removeRow( key );
      };
      resources/lib/ooui/oojs-ui-core.js on lines 10846..10848
      resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 163..165
      resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 226..228
      resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 237..239

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      mw.widgets.TableWidget.prototype.setValue = function ( row, col, value ) {
          this.model.setValue( row, col, value );
      };
      Severity: Minor
      Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js and 1 other location - About 35 mins to fix
      resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 217..219

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

      mw.widgets.TableWidget.prototype.clear = function () {
          this.model.clear();
      };
      resources/lib/ooui/oojs-ui-core.js on lines 9571..9573
      resources/lib/ooui/oojs-ui-core.js on lines 12958..12960
      resources/lib/ooui/oojs-ui-widgets.js on lines 3983..3985
      resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 233..235
      resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 251..253

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

      mw.widgets.TableWidget.prototype.clearWithProperties = function () {
          this.model.clearWithProperties();
      };
      resources/lib/ooui/oojs-ui-core.js on lines 9571..9573
      resources/lib/ooui/oojs-ui-core.js on lines 12958..12960
      resources/lib/ooui/oojs-ui-widgets.js on lines 3983..3985
      resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 233..235
      resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 244..246

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if ( this.model.getTableProperties().allowRowInsertion ) {
              this.insertionRow.connect( this, {
                  inputChange: 'onInsertionRowInputChange'
              } );
          }
      Severity: Minor
      Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js and 1 other location - About 35 mins to fix
      resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 74..78

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          if ( this.model.getTableProperties().showHeaders ) {
              this.$element.append( this.headerRow.$element );
          }
      resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 88..90
      resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 113..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          if ( this.model.getTableProperties().allowRowInsertion ) {
              this.$element.append( this.insertionRow.$element );
          }
      resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 88..90
      resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 109..111

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status