Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js

Summary

Maintainability
F
3 days
Test Coverage

Function getEntryFromPropsTable has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

mw.widgets.TableWidgetModel.static.getEntryFromPropsTable = function ( handle, table ) {
    var row = null,
        i, len;

    if ( typeof handle === 'string' ) {
Severity: Minor
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function verifyData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

mw.widgets.TableWidgetModel.prototype.verifyData = function () {
    var i, j, rowLen, colLen;

    for ( i = 0, rowLen = this.rows.length; i < rowLen; i++ ) {
        if ( this.data[ i ] === undefined ) {
Severity: Minor
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function insertRow has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

mw.widgets.TableWidgetModel.prototype.insertRow = function ( data, index, key, label ) {
    var insertIndex = ( typeof index === 'number' ) ? index : this.rows.length,
        newRowData = [],
        insertData, insertDataCell, i, len;
Severity: Minor
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function initializeProps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

mw.widgets.TableWidgetModel.prototype.initializeProps = function ( rowProps, colProps ) {
    // FIXME: Account for extra data with missing row/col metadata

    var i, len;
Severity: Minor
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

mw.widgets.TableWidgetModel.prototype.setValue = function ( row, col, value ) {
    var rowIndex, colIndex;

    if ( typeof row === 'number' ) {
        rowIndex = row;
Severity: Minor
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function insertColumn has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

mw.widgets.TableWidgetModel.prototype.insertColumn = function ( data, index, key, label ) {
    var insertIndex = ( typeof index === 'number' ) ? index : this.cols.length,
        insertDataCell, insertData, i, len;

    // Add the new column metadata
Severity: Minor
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function MwWidgetsTableWidgetModel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

mw.widgets.TableWidgetModel = function MwWidgetsTableWidgetModel( config ) {
    config = config || {};

    // Mixin constructors
    OO.EventEmitter.call( this, config );
Severity: Minor
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if ( Array.isArray( rowProps ) ) {
        for ( i = 0, len = rowProps.length; i < len; i++ ) {
            this.rows.push( {
                index: i,
                key: rowProps[ i ].key,
Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 1 other location - About 2 hrs to fix
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js on lines 165..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if ( Array.isArray( colProps ) ) {
        for ( i = 0, len = colProps.length; i < len; i++ ) {
            this.cols.push( {
                index: i,
                key: colProps[ i ].key,
Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 1 other location - About 2 hrs to fix
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js on lines 155..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

mw.widgets.TableWidgetModel.prototype.setData = function ( data ) {
    if ( Array.isArray( data ) ) {
        this.data = data;

        this.verifyData();
Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 1 other location - About 2 hrs to fix
resources/src/mediawiki.widgets/Table/mw.widgets.RowWidgetModel.js on lines 186..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

mw.widgets.TableWidgetModel.prototype.getTableProperties = function () {
    return {
        showHeaders: this.showHeaders,
        showRowLabels: this.showRowLabels,
        allowRowInsertion: this.allowRowInsertion,
Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 1 other location - About 1 hr to fix
resources/src/mediawiki.widgets/Table/mw.widgets.RowWidgetModel.js on lines 315..322

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

mw.widgets.TableWidgetModel.prototype.clear = function () {
    this.data = [];
    this.verifyData();

    this.emit( 'clear', false );
Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 1 other location - About 1 hr to fix
resources/src/mediawiki.widgets/Table/mw.widgets.RowWidgetModel.js on lines 282..287

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

mw.widgets.TableWidgetModel.prototype.getRowProperties = function ( handle ) {
    return mw.widgets.TableWidgetModel.static.getEntryFromPropsTable( handle, this.rows );
};
Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 1 other location - About 1 hr to fix
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js on lines 506..508

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

mw.widgets.TableWidgetModel.prototype.getColumnProperties = function ( handle ) {
    return mw.widgets.TableWidgetModel.static.getEntryFromPropsTable( handle, this.cols );
};
Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 1 other location - About 1 hr to fix
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js on lines 485..487

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    for ( i = insertIndex + 1, len = this.cols.length; i < len; i++ ) {
        this.cols[ i ].index++;
    }
Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 2 other locations - About 1 hr to fix
resources/src/mediawiki.widgets/Table/mw.widgets.RowWidgetModel.js on lines 243..245
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js on lines 321..323

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    for ( i = insertIndex + 1, len = this.rows.length; i < len; i++ ) {
        this.rows[ i ].index++;
    }
Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 2 other locations - About 1 hr to fix
resources/src/mediawiki.widgets/Table/mw.widgets.RowWidgetModel.js on lines 243..245
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js on lines 366..368

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    for ( i = colProps.index, len = this.cols.length; i < len; i++ ) {
        this.cols[ i ].index--;
    }
Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 2 other locations - About 1 hr to fix
resources/src/mediawiki.widgets/Table/mw.widgets.RowWidgetModel.js on lines 270..272
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js on lines 393..395

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    for ( i = rowProps.index, len = this.rows.length; i < len; i++ ) {
        this.rows[ i ].index--;
    }
Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 2 other locations - About 1 hr to fix
resources/src/mediawiki.widgets/Table/mw.widgets.RowWidgetModel.js on lines 270..272
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js on lines 423..425

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    if ( typeof row === 'number' ) {
        rowIndex = row;
    } else if ( typeof row === 'string' ) {
        rowIndex = this.getRowProperties( row ).index;
    }
Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 2 other locations - About 55 mins to fix
resources/src/mediawiki.widgets/Table/mw.widgets.RowWidgetModel.js on lines 167..171
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js on lines 252..256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    if ( typeof col === 'number' ) {
        colIndex = col;
    } else if ( typeof col === 'string' ) {
        colIndex = this.getColumnProperties( col ).index;
    }
Severity: Major
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 2 other locations - About 55 mins to fix
resources/src/mediawiki.widgets/Table/mw.widgets.RowWidgetModel.js on lines 167..171
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js on lines 246..250

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

mw.widgets.TableWidgetModel.prototype.setupTable = function () {
    this.verifyData();
    this.buildTable();
};
Severity: Minor
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 1 other location - About 50 mins to fix
resources/src/mediawiki.widgets/Table/mw.widgets.RowWidgetModel.js on lines 109..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

mw.widgets.TableWidgetModel.prototype.getAllRowProperties = function () {
    return this.rows.slice();
};
Severity: Minor
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 2 other locations - About 35 mins to fix
resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js on lines 115..117
resources/src/mediawiki.widgets/mw.widgets.TitlesMultiselectWidget.js on lines 90..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    this.cols.splice( insertIndex, 0, {
        index: insertIndex,
        key: key || undefined,
        label: label || undefined
    } );
Severity: Minor
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 1 other location - About 30 mins to fix
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js on lines 300..304

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    this.rows.splice( insertIndex, 0, {
        index: insertIndex,
        key: key || undefined,
        label: label || undefined
    } );
Severity: Minor
Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js and 1 other location - About 30 mins to fix
resources/src/mediawiki.widgets/Table/mw.widgets.TableWidgetModel.js on lines 346..350

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status