wikimedia/mediawiki-core

View on GitHub
resources/src/mediawiki.widgets/mw.widgets.SearchInputWidget.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function MwWidgetsSearchInputWidget has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    mw.widgets.SearchInputWidget = function MwWidgetsSearchInputWidget( config ) {
        // The parent constructors will detach this from the DOM, and won't
        // be reattached until after this function is completed. As such
        // grab a handle here. If no config.$input is passed tracking of
        // form submissions won't work.
Severity: Minor
Found in resources/src/mediawiki.widgets/mw.widgets.SearchInputWidget.js - About 1 hr to fix

    Function getOptionsFromData has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        mw.widgets.SearchInputWidget.prototype.getOptionsFromData = function ( data ) {
            var items = [],
                titles = data.data[ 1 ],
                descriptions = data.data[ 2 ],
                urls = data.data[ 3 ],
    Severity: Minor
    Found in resources/src/mediawiki.widgets/mw.widgets.SearchInputWidget.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          mw.widgets.SearchInputWidget.prototype.setReadOnly = function ( state ) {
              mw.widgets.SearchInputWidget.super.prototype.setReadOnly.call( this, state );
              this.updateSearchIndicator();
              return this;
          };
      resources/lib/ooui/oojs-ui-core.js on lines 12184..12188

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          mw.widgets.SearchInputWidget.prototype.getInputElement = function () {
              return $( '<input>' ).attr( 'type', 'search' );
          };
      resources/lib/ooui/oojs-ui-core.js on lines 10436..10438
      resources/lib/ooui/oojs-ui-core.js on lines 10945..10947

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status