Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js

Summary

Maintainability
C
1 day
Test Coverage

File mw.widgets.TitleWidget.js has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * MediaWiki Widgets - TitleWidget class.
 *
 * @copyright 2011-2015 MediaWiki Widgets Team and others; see AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
Severity: Minor
Found in resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js - About 3 hrs to fix

    Function getOptionsFromData has 86 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        mw.widgets.TitleWidget.prototype.getOptionsFromData = function ( data ) {
        var currentPageName = new mw.Title( mw.config.get( 'wgRelevantPageName' ) ).getPrefixedText(),
            items = [],
            titles = [],
            disambigs = [],
    Severity: Major
    Found in resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js - About 3 hrs to fix

      Function getSuggestionsPromise has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          mw.widgets.TitleWidget.prototype.getSuggestionsPromise = function () {
        var api = this.getApi(),
            query = this.getQueryValue(),
            widget = this,
            promiseAbortObject = { abort: function () {
      Severity: Major
      Found in resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js - About 2 hrs to fix

        Function getSectionSuggestions has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            mw.widgets.TitleWidget.prototype.getSectionSuggestions = function ( title, fragmentQuery ) {
        var widget = this;
        var normalizedTitle = mw.Title.newFromText( title || mw.config.get( 'wgRelevantPageName' ) );
        if ( !normalizedTitle ) {
            return $.Deferred().resolve( [] ).promise();
        Severity: Minor
        Found in resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js - About 1 hr to fix

          Function MwWidgetsTitleWidget has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              mw.widgets.TitleWidget = function MwWidgetsTitleWidget( config ) {
        // Config initialization
        config = $.extend( {
            maxLength: 255,
            limit: 10
          Severity: Minor
          Found in resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                mw.widgets.TitleWidget.prototype.createOptionWidget = function ( data ) {
        return new mw.widgets.TitleOptionWidget( data );
    };
            Severity: Minor
            Found in resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js and 1 other location - About 40 mins to fix
            resources/lib/ooui/oojs-ui-widgets.js on lines 5656..5658

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status