Sign upLogin

wikimedia/mediawiki-extensions-MobileFrontend

View on GitHub
Star
src/mobile.editor.overlay/EditorOverlayBase.js

Summary

Maintainability
D
2 days
Test Coverage

File EditorOverlayBase.js has 467 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* global $ */
/**
 * @class EditorOverlayBase
 * @private
 */
Severity: Minor
Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 7 hrs to fix

    `` has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    mfExtend( EditorOverlayBase, Overlay, {
    /**
     * @memberof EditorOverlayBase
     * @instance
     * @mixes Overlay#defaults
    Severity: Minor
    Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 3 hrs to fix

      Function createAnonWarning has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          createAnonWarning: function ( options ) {
        const $actions = $( '<div>' ).addClass( 'actions' ),
            // Use MediaWiki ResourceLoader require(), not Webpack require()
            contLangMessages = (
      Severity: Minor
      Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 1 hr to fix

        Function onBeforeExit has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            onBeforeExit: function ( exit, cancel ) {
        const self = this;
        if ( this.hasChanged() && !this.switching ) {
            if ( !this.windowManager ) {
                this.windowManager = OO.ui.getWindowManager();
        Severity: Minor
        Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 1 hr to fix

          Function showEditNotices has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              showEditNotices: function () {
        const overlay = this;
        if ( mw.config.get( 'wgMFEditNoticesFeatureConflict' ) ) {
            return;
        }
          Severity: Minor
          Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 1 hr to fix

            Function preRender has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                preRender: function () {
        const options = this.options;

        this.options.headers = [
            headers.formHeader(
            Severity: Minor
            Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 1 hr to fix

              Function EditorOverlayBase has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function EditorOverlayBase( params ) {
    const
        options = util.extend(
            true,
            {
              Severity: Minor
              Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 1 hr to fix

                Function onSaveComplete has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    onSaveComplete: function ( newRevId, redirectUrl, tempUserCreated ) {
        const
            self = this;

        this.saved = true;
                Severity: Minor
                Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 1 hr to fix

                  Function onBeforeExit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      onBeforeExit: function ( exit, cancel ) {
        const self = this;
        if ( this.hasChanged() && !this.switching ) {
            if ( !this.windowManager ) {
                this.windowManager = OO.ui.getWindowManager();
                  Severity: Minor
                  Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function onSaveComplete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      onSaveComplete: function ( newRevId, redirectUrl, tempUserCreated ) {
        const
            self = this;

        this.saved = true;
                  Severity: Minor
                  Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function handleCaptcha has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      handleCaptcha: function ( details ) {
        const self = this,
            $input = this.$el.find( '.captcha-word' );

        if ( this.captchaShown ) {
                  Severity: Minor
                  Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      logFeatureUse: function ( data ) {
        mw.track( 'visualEditorFeatureUse', util.extend( data, {
            // eslint-disable-next-line camelcase
            editor_interface: this.editor
        } ) );
                  Severity: Minor
                  Found in src/mobile.editor.overlay/EditorOverlayBase.js and 1 other location - About 35 mins to fix
                  src/mobile.editor.overlay/EditorOverlayBase.js on lines 188..193

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      log: function ( data ) {
        mw.track( 'editAttemptStep', util.extend( data, {
            // eslint-disable-next-line camelcase
            editor_interface: this.editor
        } ) );
                  Severity: Minor
                  Found in src/mobile.editor.overlay/EditorOverlayBase.js and 1 other location - About 35 mins to fix
                  src/mobile.editor.overlay/EditorOverlayBase.js on lines 201..206

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status