Sign upLogin

wikimedia/mediawiki-extensions-MobileFrontend

View on GitHub
Star
src/mobile.editor.overlay/SourceEditorOverlay.js

Summary

Maintainability
D
1 day
Test Coverage

File SourceEditorOverlay.js has 373 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const EditorOverlayBase = require( './EditorOverlayBase' ),
    util = require( '../mobile.startup/util' ),
    icons = require( '../mobile.startup/icons' ),
    Section = require( '../mobile.startup/Section' ),
    saveFailureMessage = require( './saveFailureMessage' ),
Severity: Minor
Found in src/mobile.editor.overlay/SourceEditorOverlay.js - About 4 hrs to fix

    Function postRender has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        postRender: function () {
        const self = this;

        // log edit attempt
        this.log( { action: 'ready' } );
    Severity: Major
    Found in src/mobile.editor.overlay/SourceEditorOverlay.js - About 2 hrs to fix

      Function _switchToVisualEditor has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _switchToVisualEditor: function ( wikitext ) {
        const self = this;
        this.log( {
            action: 'abort',
            type: 'switchnochange',
      Severity: Minor
      Found in src/mobile.editor.overlay/SourceEditorOverlay.js - About 1 hr to fix

        Function onStageChanges has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            onStageChanges: function () {
        const self = this,
            params = {
                text: this.getContent()
            };
        Severity: Minor
        Found in src/mobile.editor.overlay/SourceEditorOverlay.js - About 1 hr to fix

          Function SourceEditorOverlay has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function SourceEditorOverlay( options, dataPromise ) {
    this.isFirefox = /firefox/i.test( window.navigator.userAgent );
    this.gateway = new EditorGateway( {
        api: options.api,
        title: options.title,
          Severity: Minor
          Found in src/mobile.editor.overlay/SourceEditorOverlay.js - About 1 hr to fix

            Function onSaveBegin has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                onSaveBegin: function () {
        const self = this,
            options = {
                summary: this.getEditSummary()
            };
            Severity: Minor
            Found in src/mobile.editor.overlay/SourceEditorOverlay.js - About 1 hr to fix

              Function onSaveComplete has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  onSaveComplete: function ( newRevId, redirectUrl ) {
        EditorOverlayBase.prototype.onSaveComplete.apply( this, arguments );

        // The parent class changes the location hash in a setTimeout, so wait
        // for that to happen before reloading.
              Severity: Minor
              Found in src/mobile.editor.overlay/SourceEditorOverlay.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _resizeEditor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  _resizeEditor: function () {
        let scrollTop, container, $scrollContainer;

        if ( !this.$scrollContainer ) {
            container = OO.ui.Element.static
              Severity: Minor
              Found in src/mobile.editor.overlay/SourceEditorOverlay.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              newOverlay.getLoadingPromise().then( function () {
                    self.switching = true;
                    self.overlayManager.replaceCurrent( newOverlay );
                    self.switching = false;
                } );
              Severity: Major
              Found in src/mobile.editor.overlay/SourceEditorOverlay.js and 1 other location - About 1 hr to fix
              src/mobile.editor.overlay/VisualEditorOverlay.js on lines 318..322

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status