Sign upLogin

wikimedia/mediawiki-extensions-MobileFrontend

View on GitHub
Star
src/mobile.startup/Toggler.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function _enable has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Toggler.prototype._enable = function () {
    const self = this;

    // FIXME This should use .find() instead of .children(), some extensions like Wikibase
    // want to toggle other headlines than direct descendants of $container. (T95889)
Severity: Major
Found in src/mobile.startup/Toggler.js - About 2 hrs to fix

    Function _enable has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    Toggler.prototype._enable = function () {
    const self = this;

    // FIXME This should use .find() instead of .children(), some extensions like Wikibase
    // want to toggle other headlines than direct descendants of $container. (T95889)
    Severity: Minor
    Found in src/mobile.startup/Toggler.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function toggle has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Toggler.prototype.toggle = function ( $heading, fromSaved ) {
    if ( !fromSaved && $heading.hasClass( 'collapsible-heading-disabled' ) ) {
        return false;
    }
    Severity: Minor
    Found in src/mobile.startup/Toggler.js - About 1 hr to fix

      Function reveal has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      Toggler.prototype.reveal = function ( id ) {
    let $target;
    // jQuery will throw for hashes containing certain characters which can break toggling
    try {
        $target = this.$container.find( '#' + escapeSelector( id ) );
      Severity: Minor
      Found in src/mobile.startup/Toggler.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function toggle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      Toggler.prototype.toggle = function ( $heading, fromSaved ) {
    if ( !fromSaved && $heading.hasClass( 'collapsible-heading-disabled' ) ) {
        return false;
    }
      Severity: Minor
      Found in src/mobile.startup/Toggler.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status