Sign upLogin

wikimedia/mediawiki-extensions-MobileFrontend

View on GitHub
Star
src/mobile.startup/search/SearchOverlay.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function performSearch has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    performSearch( query ) {
        const
            self = this,
            api = this.api,
            delay = this.gateway.isCached( query ) ? 0 : SEARCH_DELAY;
Severity: Minor
Found in src/mobile.startup/search/SearchOverlay.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function performSearch has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    performSearch( query ) {
        const
            self = this,
            api = this.api,
            delay = this.gateway.isCached( query ) ? 0 : SEARCH_DELAY;
Severity: Minor
Found in src/mobile.startup/search/SearchOverlay.js - About 1 hr to fix

    Function postRender has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        postRender() {
        const self = this,
            searchResults = new SearchResultsView( {
                searchContentLabel: mw.msg( 'mobile-frontend-search-content' ),
                noResultsMsg: mw.msg( 'mobile-frontend-search-no-results' ),
    Severity: Minor
    Found in src/mobile.startup/search/SearchOverlay.js - About 1 hr to fix

      Function SearchOverlay has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function SearchOverlay( params ) {
    const header = searchHeader(
            params.placeholderMsg,
            params.action || mw.config.get( 'wgScript' ),
            ( query ) => this.performSearch( query ),
      Severity: Minor
      Found in src/mobile.startup/search/SearchOverlay.js - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status