File ext.translate.editor.helpers.js
has 528 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*!
* Translate editor additional helper functionality
*/
( function () {
'use strict';
Function showTranslationMemory
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
showTranslationMemory: function ( translations ) {
if ( !translations.length ) {
return;
}
Function showEditSummaries
has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
showEditSummaries: function ( editsummaries ) {
if ( !editsummaries.length ) {
return;
}
Function showMessageDocumentation
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
showMessageDocumentation: function ( documentation ) {
if ( !mw.config.get( 'wgTranslateDocumentationLanguageCode' ) ) {
return;
}
Function showTranslationHelpers
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
showTranslationHelpers: function () {
// API call to get translation suggestions from other languages
// callback should render suggestions to the editor's info column
var api = new mw.Api();
Function showMachineTranslations
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
showMachineTranslations: function ( suggestions ) {
if ( !suggestions.length ) {
return;
}
Function saveDocumentation
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
saveDocumentation: function () {
var translateEditor = this,
api = new mw.Api(),
newDocumentation = translateEditor.$editor.find( '.tux-textarea-documentation' ).val();
Function showAssistantLanguages
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
showAssistantLanguages: function ( translations ) {
if ( translations.error ) {
return;
}
Function addInsertables
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
addInsertables: function ( insertables ) {
var count = insertables.length,
$sourceMessage = this.$editor.find( '.sourcemessage' ),
$buttonArea = this.$editor.find( '.tux-editor-insert-buttons' ),
$textarea = this.$editor.find( '.tux-textarea-translation' );
Function onShowTranslationMemorySources
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
onShowTranslationMemorySources: function ( e, suggestion ) {
e.stopPropagation();
if ( suggestion.$sourcesElement ) {
suggestion.$sourcesElement.toggleClass( 'hide' );
Identical blocks of code found in 2 locations. Consider refactoring. Open
var $infoColumnBlock = this.$editor.find( '.infocolumn-block' ),
$editColumn = this.$editor.find( '.editcolumn' ),
$messageDescEditor = $infoColumnBlock.find( '.message-desc-editor' ),
$messageDescViewer = $infoColumnBlock.find( '.message-desc-viewer' );
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 62.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
var $infoColumnBlock = this.$editor.find( '.infocolumn-block' ),
$editColumn = this.$editor.find( '.editcolumn' ),
$messageDescEditor = $infoColumnBlock.find( '.message-desc-editor' ),
$messageDescViewer = $infoColumnBlock.find( '.message-desc-viewer' );
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 62.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76