Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
resources/js/ext.translate.editor.js

Summary

Maintainability
F
6 days
Test Coverage

File ext.translate.editor.js has 1033 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* global autosize */

( function () {
    'use strict';
Severity: Major
Found in resources/js/ext.translate.editor.js - About 2 days to fix

    Function prepareEditorColumn has 332 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            prepareEditorColumn: function () {
            var translateEditor = this,
                $discardChangesButton = $( [] ),
                $saveButton = $( [] ),
                $messageTools = translateEditor.createMessageTools(),
    Severity: Major
    Found in resources/js/ext.translate.editor.js - About 1 day to fix

      Function prepareInfoColumn has 111 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              prepareInfoColumn: function () {
            var $infoColumn = $( '<div>' ).addClass( 'infocolumn' ),
                translateEditor = this;

            $infoColumn.append( $( '<div>' )
      Severity: Major
      Found in resources/js/ext.translate.editor.js - About 4 hrs to fix

        Function save has 69 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                save: function () {
            var translateEditor = this;

            mw.hook( 'mw.translate.editor.beforeSubmit' ).fire( translateEditor.$editor );
            var translation = translateEditor.$editor.find( '.tux-textarea-translation' ).val();
        Severity: Major
        Found in resources/js/ext.translate.editor.js - About 2 hrs to fix

          Function createMessageTools has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  createMessageTools: function () {
            var $editItem = this.createMessageToolsItem(
                'message-tools-edit',
                {
                    title: this.message.title,
          Severity: Major
          Found in resources/js/ext.translate.editor.js - About 2 hrs to fix

            Function validateTranslation has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    validateTranslation: function () {
            var translateEditor = this,
                $textarea = translateEditor.$editor.find( '.tux-textarea-translation' );

            var api = new mw.Api();
            Severity: Minor
            Found in resources/js/ext.translate.editor.js - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                              if (
                    e.type === 'keydown' &&
                    e.altKey === true &&
                    e.ctrlKey === false &&
                    e.shiftKey === false &&
              Severity: Major
              Found in resources/js/ext.translate.editor.js - About 40 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    $.fn.translateeditor = function ( options ) {
        return this.each( function () {
            var $this = $( this ),
                data = $this.data( 'translateeditor' );
                Severity: Major
                Found in resources/js/ext.translate.editor.js and 1 other location - About 4 hrs to fix
                resources/js/ext.translate.messagetable.js on lines 846..859

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 121.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            $infoColumn.append( $( '<div>' )
                .addClass( 'row edit-summaries-title hide' )
                .append(
                    $( '<span>' ).text( mw.msg( 'tux-editor-latest-updates-title' ) )
                )
                Severity: Minor
                Found in resources/js/ext.translate.editor.js and 1 other location - About 35 mins to fix
                resources/js/ext.translate.special.aggregategroups.js on lines 317..327

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status