Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
resources/js/ext.translate.proofread.js

Summary

Maintainability
D
1 day
Test Coverage

Function render has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        render: function () {
            // List of all reviewers
            var reviewers = this.message.properties.reviewers || [];
            // The id of the current user, converted to string as the are in reviewers
            var userId = String( mw.config.get( 'wgUserId' ) );
Severity: Major
Found in resources/js/ext.translate.proofread.js - About 3 hrs to fix

    Function proofread has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            proofread: function () {
            var message = this.message,
                $message = this.$message,
                api = new mw.Api();
    Severity: Minor
    Found in resources/js/ext.translate.proofread.js - About 1 hr to fix

      Function init has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              init: function () {
            var that = this;

            this.render();
      Severity: Minor
      Found in resources/js/ext.translate.proofread.js - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            $.fn.proofread = function ( options ) {
        return this.each( function () {
            var $this = $( this ),
                data = $this.data( 'proofread' );
        Severity: Major
        Found in resources/js/ext.translate.proofread.js and 2 other locations - About 2 hrs to fix
        resources/js/ext.translate.pagemode.js on lines 140..149
        resources/js/ext.translate.statsbar.js on lines 172..181

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 89.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            function Proofread( element, options ) {
        this.$message = $( element );
        this.options = options;
        this.message = this.options.message;
        this.init();
        Severity: Major
        Found in resources/js/ext.translate.proofread.js and 1 other location - About 2 hrs to fix
        resources/js/ext.translate.pagemode.js on lines 26..32

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if ( this.options.targetlangcode === mw.config.get( 'wgTranslateDocumentationLanguageCode' ) ) {
                targetLangAttrib = mw.config.get( 'wgContentLanguage' );
            } else {
                targetLangAttrib = this.options.targetlangcode;
            }
        Severity: Major
        Found in resources/js/ext.translate.proofread.js and 1 other location - About 1 hr to fix
        resources/js/ext.translate.pagemode.js on lines 77..81

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        beforeSave: function ( translation ) {
                    that.$message.find( '.tux-proofread-translation' )
                        .html( mw.translate.formatMessageGently( translation || '', that.message.key ) )
                        .addClass( 'highlight' );
                },
        Severity: Major
        Found in resources/js/ext.translate.proofread.js and 1 other location - About 1 hr to fix
        resources/js/ext.translate.pagemode.js on lines 50..54

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            that.$message.find( '.tux-proofread-status' )
                        .removeClass( 'translated fuzzy proofread untranslated' )
                        .addClass( that.message.properties.status );
        Severity: Minor
        Found in resources/js/ext.translate.proofread.js and 1 other location - About 35 mins to fix
        resources/js/ext.translate.pagemode.js on lines 62..64

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                $( '<div>' )
                            .addClass( 'five columns tux-proofread-source' )
                            .attr( {
                                lang: this.options.sourcelangcode,
                                dir: sourceLangDir
        Severity: Minor
        Found in resources/js/ext.translate.proofread.js and 1 other location - About 30 mins to fix
        resources/js/ext.translate.pagemode.js on lines 97..103

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status