Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
resources/src/ext.translate.entity.selector/index.js

Summary

Maintainability
D
1 day
Test Coverage

Function EntitySelectorWidget has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var EntitySelectorWidget = function ( config ) {
    // Parent constructor
    OO.ui.TextInputWidget.call( this, {
        classes: [ 'tes-entity-selector' ],
        placeholder: mw.msg( 'translate-tes-type-to-search' ),
Severity: Major
Found in resources/src/ext.translate.entity.selector/index.js - About 2 hrs to fix

    Function getLookupMenuOptionsFromData has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    EntitySelectorWidget.prototype.getLookupMenuOptionsFromData = function ( response ) {
    var groups = response.groups || [];
    var messages = response.messages || [];
    var finalResult = [];
    var i = 0;
    Severity: Minor
    Found in resources/src/ext.translate.entity.selector/index.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getLookupMenuOptionsFromData has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    EntitySelectorWidget.prototype.getLookupMenuOptionsFromData = function ( response ) {
    var groups = response.groups || [];
    var messages = response.messages || [];
    var finalResult = [];
    var i = 0;
    Severity: Major
    Found in resources/src/ext.translate.entity.selector/index.js - About 2 hrs to fix

      Function getLookupRequest has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      EntitySelectorWidget.prototype.getLookupRequest = function () {
    var value = this.getValue();
    var widget = this;

    if ( !this.allowSuggestionsWhenEmpty && value === '' ) {
      Severity: Minor
      Found in resources/src/ext.translate.entity.selector/index.js - About 1 hr to fix

        Function EntitySelectorWidget has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        var EntitySelectorWidget = function ( config ) {
    // Parent constructor
    OO.ui.TextInputWidget.call( this, {
        classes: [ 'tes-entity-selector' ],
        placeholder: mw.msg( 'translate-tes-type-to-search' ),
        Severity: Minor
        Found in resources/src/ext.translate.entity.selector/index.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            this.messageLabel = new OO.ui.MenuOptionWidget( {
        label: mw.msg( 'translate-tes-optgroup-message' ),
        disabled: true,
        highlightable: false,
        pressable: false,
        Severity: Major
        Found in resources/src/ext.translate.entity.selector/index.js and 1 other location - About 1 hr to fix
        resources/src/ext.translate.entity.selector/index.js on lines 48..54

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            this.groupLabel = new OO.ui.MenuOptionWidget( {
        label: mw.msg( 'translate-tes-optgroup-group' ),
        disabled: true,
        highlightable: false,
        pressable: false,
        Severity: Major
        Found in resources/src/ext.translate.entity.selector/index.js and 1 other location - About 1 hr to fix
        resources/src/ext.translate.entity.selector/index.js on lines 40..46

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        new OO.ui.MenuOptionWidget( {
                    data: {
                        type: 'group',
                        data: groups[ i ].group
                    },
        Severity: Minor
        Found in resources/src/ext.translate.entity.selector/index.js and 1 other location - About 50 mins to fix
        resources/src/ext.translate.entity.selector/index.js on lines 185..191

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    var messageOption = new OO.ui.MenuOptionWidget( {
                data: {
                    type: 'message',
                    data: messages[ i ].pattern
                },
        Severity: Minor
        Found in resources/src/ext.translate.entity.selector/index.js and 1 other location - About 50 mins to fix
        resources/src/ext.translate.entity.selector/index.js on lines 168..174

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status