Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
resources/src/ext.translate.groupselector/index.js

Summary

Maintainability
D
1 day
Test Coverage

File index.js has 414 lines of code (exceeds 250 allowed). Consider refactoring.
Open

( function () {
    'use strict';

    var groupsLoader, delay;
Severity: Minor
Found in resources/src/ext.translate.groupselector/index.js - About 5 hrs to fix

    Function prepareSelectorMenu has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            prepareSelectorMenu: function () {
            this.$menu = $( '<div>' )
                .addClass( 'tux-groupselector' )
                .addClass( 'grid hide' );
    Severity: Major
    Found in resources/src/ext.translate.groupselector/index.js - About 2 hrs to fix

      Function listen has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              listen: function () {
            var groupSelector = this;

            // Hide the selector panel when clicking outside of it
            $( document.documentElement ).on( 'click', this.hide.bind( this ) );
      Severity: Minor
      Found in resources/src/ext.translate.groupselector/index.js - About 2 hrs to fix

        Function prepareMessageGroupRow has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                prepareMessageGroupRow: function ( messagegroup ) {
            var $row = $( '<div>' )
                .addClass( 'row tux-grouplist__item' )
                .attr( 'data-msggroupid', messagegroup.id )
                .data( 'msggroup', messagegroup );
        Severity: Minor
        Found in resources/src/ext.translate.groupselector/index.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ( messagegroup.icon && messagegroup.icon.raster ) {
                style += 'background-image: url(--);';
                style = style.replace( /--/g, messagegroup.icon.raster );
            }
          Severity: Minor
          Found in resources/src/ext.translate.groupselector/index.js and 1 other location - About 55 mins to fix
          resources/src/ext.translate.groupselector/index.js on lines 579..582

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ( messagegroup.icon && messagegroup.icon.vector ) {
                style += 'background-image: url(--);';
                style = style.replace( /--/g, messagegroup.icon.vector );
            }
          Severity: Minor
          Found in resources/src/ext.translate.groupselector/index.js and 1 other location - About 55 mins to fix
          resources/src/ext.translate.groupselector/index.js on lines 574..577

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              delay = ( function () {
        var timer = 0;

        return function ( callback, milliseconds ) {
            clearTimeout( timer );
          Severity: Minor
          Found in resources/src/ext.translate.groupselector/index.js and 1 other location - About 50 mins to fix
          resources/js/ext.translate.special.managetranslatorsandbox.js on lines 729..736

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status