Sign upLogin

wikimedia/mediawiki-extensions-UploadWizard

View on GitHub
Star
resources/controller/uw.controller.Upload.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function validateFile has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    uw.controller.Upload.prototype.validateFile = function ( upload ) {
        var extension,
            i,
            actualMaxSize = mw.UploadWizard.config.maxMwUploadSize,
Severity: Minor
Found in resources/controller/uw.controller.Upload.js - About 1 hr to fix

    Function UWControllerUpload has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        uw.controller.Upload = function UWControllerUpload( api, config ) {
        var step = this;

        uw.controller.Step.call(
            this,
    Severity: Minor
    Found in resources/controller/uw.controller.Upload.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                      return false;
      Severity: Major
      Found in resources/controller/uw.controller.Upload.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return true;
        Severity: Major
        Found in resources/controller/uw.controller.Upload.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return false;
          Severity: Major
          Found in resources/controller/uw.controller.Upload.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                uw.controller.Upload.prototype.moveNext = function () {
        this.removeErrorUploads();

        uw.controller.Step.prototype.moveNext.call( this );
    };
            Severity: Major
            Found in resources/controller/uw.controller.Upload.js and 1 other location - About 1 hr to fix
            resources/controller/uw.controller.Details.js on lines 83..87

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    this.queue = new uw.ConcurrentQueue( {
            count: this.config.maxSimultaneousConnections,
            action: this.transitionOne.bind( this )
        } );
            Severity: Minor
            Found in resources/controller/uw.controller.Upload.js and 1 other location - About 45 mins to fix
            resources/controller/uw.controller.Details.js on lines 40..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status