wikimedia/mediawiki-extensions-UploadWizard

Function processDestinationCheck has 52 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    uw.TitleDetailsWidget.prototype.processDestinationCheck = function ( result ) {
        var messageKey, messageParams, errors, titleString;

        if ( result.unique.isUnique && result.blacklist.notBlacklisted && !result.unique.isProtected ) {
            return [];

Function validateTitleInput has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    uw.TitleDetailsWidget.prototype.validateTitleInput = function ( value ) {
        var
            errors = [],
            processDestinationCheck = this.processDestinationCheck,
            title = this.buildTitleFromInput( value ),

Avoid too many return statements within this function.

Open

        return mw.DestinationChecker.checkTitle( title.getPrefixedText() )
            .then( ( result ) => {
                var moreErrors = processDestinationCheck( result );
                if ( result.blacklist.unavailable ) {
                    // We don't have a title blacklist, so just check for some likely undesirable patterns.

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if ( this.config.maxLength && length > this.config.maxLength ) {
            errors.push( mw.message( 'mwe-upwiz-error-title-too-long', this.config.maxLength ) );
            return $.Deferred().resolve( errors ).promise();
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if ( this.config.minLength && length < this.config.minLength ) {
            errors.push( mw.message( 'mwe-upwiz-error-title-too-short', this.config.minLength ) );
            return $.Deferred().resolve( errors ).promise();
        }

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    uw.TitleDetailsWidget.prototype.getWikiText = function () {
        return this.titleInput.getValue().trim();
    };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if ( value === '' ) {
            errors.push( mw.message( 'mwe-upwiz-error-title-blank' ) );
            return $.Deferred().resolve( errors ).promise();
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if ( !title ) {
            errors.push( mw.message( 'mwe-upwiz-error-title-invalid' ) );
            return $.Deferred().resolve( errors ).promise();
        }

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    uw.TitleDetailsWidget.prototype.getSerialized = function () {
        return {
            title: this.titleInput.getValue()
        };
    };

• Read up
  Read up