Sign upLogin

wikimedia/mediawiki-extensions-UploadWizard

View on GitHub
Star
resources/mw.FlickrChecker.js

Summary

Maintainability
F
3 days
Test Coverage

File mw.FlickrChecker.js has 498 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-disable camelcase, no-underscore-dangle */

/**
 * @param ui
 * @param selectButton
Severity: Minor
Found in resources/mw.FlickrChecker.js - About 7 hrs to fix

    Function getPhotos has 122 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        getPhotos: function ( mode, options ) {
        this.selectButton.setLabel( mw.message( 'mwe-upwiz-select-flickr' ).text() );
        this.selectButton.setDisabled( true );

        var req = $.extend( {}, options, {
    Severity: Major
    Found in resources/mw.FlickrChecker.js - About 4 hrs to fix

      Function getPhoto has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          getPhoto: function ( photoIdMatches ) {
        var checker = this;
        var photoId = photoIdMatches[ 1 ];

        return this.flickrRequest( {
      Severity: Major
      Found in resources/mw.FlickrChecker.js - About 2 hrs to fix

        Function checkFlickr has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            checkFlickr: function ( flickrInputUrl ) {
        var photoIdMatches, albumIdMatches, userCollectionMatches, userPhotostreamMatches, groupPoolMatches, userGalleryMatches, userFavoritesMatches;

        photoIdMatches = flickrInputUrl.match( /flickr\.com\/(?:x\/t\/[^/]+\/)?photos\/[^/]+\/([0-9]+)/ );
        albumIdMatches = flickrInputUrl.match( /flickr\.com\/photos\/[^/]+\/(sets|albums)\/([0-9]+)/ );
        Severity: Minor
        Found in resources/mw.FlickrChecker.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function checkFlickr has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            checkFlickr: function ( flickrInputUrl ) {
        var photoIdMatches, albumIdMatches, userCollectionMatches, userPhotostreamMatches, groupPoolMatches, userGalleryMatches, userFavoritesMatches;

        photoIdMatches = flickrInputUrl.match( /flickr\.com\/(?:x\/t\/[^/]+\/)?photos\/[^/]+\/([0-9]+)/ );
        albumIdMatches = flickrInputUrl.match( /flickr\.com\/photos\/[^/]+\/(sets|albums)\/([0-9]+)/ );
        Severity: Minor
        Found in resources/mw.FlickrChecker.js - About 1 hr to fix

          Function buildCollectionLinks has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              buildCollectionLinks: function ( appendId, data ) {
        var $elem = $( '<ul>' );
        if ( appendId ) {
            $elem.attr( 'id', 'mwe-upwiz-files-collection-chooser' );
        }
          Severity: Minor
          Found in resources/mw.FlickrChecker.js - About 1 hr to fix

            Function setImageURL has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                setImageURL: function ( index ) {
        var upload = this.imageUploads[ index ];
        var photoId = upload.photoId;
        var checker = this;
            Severity: Minor
            Found in resources/mw.FlickrChecker.js - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                      if ( albumIdMatches || photoIdMatches || userCollectionMatches || userPhotostreamMatches ||
            groupPoolMatches || userGalleryMatches || userFavoritesMatches ) {
            // eslint-disable-next-line no-jquery/no-global-selector
            $( '#mwe-upwiz-upload-add-flickr-container' ).hide();
            this.imageUploads = [];
              Severity: Major
              Found in resources/mw.FlickrChecker.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        return $.when( flickrPromise, this.getBlacklist() ).then( ( photoset, blacklist ) => {
            var sourceURL;
            var checkboxes = [];
            var checkboxesWidget = new OO.ui.CheckboxMultiselectWidget();
            var x = 0;
                Severity: Major
                Found in resources/mw.FlickrChecker.js and 1 other location - About 1 hr to fix
                resources/mw.FlickrChecker.js on lines 518..593

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 56.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        return this.flickrRequest( {
            method: 'flickr.photos.getInfo',
            photo_id: photoId
        } ).then( ( data ) => {
            if ( !data.photo ) {
                Severity: Major
                Found in resources/mw.FlickrChecker.js and 1 other location - About 1 hr to fix
                resources/mw.FlickrChecker.js on lines 373..504

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 56.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                if ( mode === 'photoset' ) {
                    ownerId = photoset.owner;
                    sourceURL = 'https://www.flickr.com/photos/' + photoset.owner + '/' + item.id + '/';
                } else if ( mode === 'photos' ) {
                    ownerId = item.owner;
                Severity: Minor
                Found in resources/mw.FlickrChecker.js and 1 other location - About 35 mins to fix
                resources/mw.FlickrChecker.js on lines 392..395

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                } else if ( mode === 'photos' ) {
                    ownerId = item.owner;
                    sourceURL = 'https://www.flickr.com/photos/' + item.owner + '/' + item.id + '/';
                }
                Severity: Minor
                Found in resources/mw.FlickrChecker.js and 1 other location - About 35 mins to fix
                resources/mw.FlickrChecker.js on lines 389..395

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status