Sign upLogin

wikimedia/mediawiki-extensions-UploadWizard

View on GitHub
Star
resources/mw.UploadWizardLicenseInput.js

Summary

Maintainability
C
1 day
Test Coverage

Function UploadWizardLicenseInput has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

mw.UploadWizardLicenseInput = function ( config, count, api ) {
    mw.UploadWizardLicenseInput.super.call( this );
    OO.ui.mixin.GroupElement.call( this );

    this.count = count;
Severity: Major
Found in resources/mw.UploadWizardLicenseInput.js - About 3 hrs to fix

    Function getErrors has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        getErrors: function () {
        var errors = $.Deferred().resolve( [] ).promise();
        var addError = function ( message ) {
            errors = errors.then( ( errors ) => {
                errors.push( mw.message( message ) );
    Severity: Minor
    Found in resources/mw.UploadWizardLicenseInput.js - About 1 hr to fix

      Function setValues has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          setValues: function ( values, groupName ) {
        var selectedGroups = [];

        var input = this;
        this.getItems().forEach( ( group ) => {
      Severity: Minor
      Found in resources/mw.UploadWizardLicenseInput.js - About 1 hr to fix

        Function UploadWizardLicenseInput has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        mw.UploadWizardLicenseInput = function ( config, count, api ) {
    mw.UploadWizardLicenseInput.super.call( this );
    OO.ui.mixin.GroupElement.call( this );

    this.count = count;
        Severity: Minor
        Found in resources/mw.UploadWizardLicenseInput.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

            if ( config.licenseGroups === undefined ) {
        var group = new mw.uploadWizard.LicenseGroup( config, this.type, this.api, this.count );
        groups.push( group );
        this.$element.append( this.$group );
    } else {
        Severity: Major
        Found in resources/mw.UploadWizardLicenseInput.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      } else if ( input.type === 'checkbox' ) {
                option = new OO.ui.CheckboxMultioptionWidget( {
                    label: new OO.ui.HtmlSnippet( label ),
                    classes: classes
                } );
          Severity: Minor
          Found in resources/mw.UploadWizardLicenseInput.js and 1 other location - About 35 mins to fix
          resources/mw.UploadWizardLicenseInput.js on lines 64..74

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ( input.type === 'radio' ) {
                option = new OO.ui.RadioOptionWidget( {
                    label: new OO.ui.HtmlSnippet( label ),
                    classes: classes
                } );
          Severity: Minor
          Found in resources/mw.UploadWizardLicenseInput.js and 1 other location - About 35 mins to fix
          resources/mw.UploadWizardLicenseInput.js on lines 69..74

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status