wikimedia/mediawiki-extensions-UploadWizard

File mw.UploadWizardUpload.js has 541 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/**
 * Represents the upload -- in its local and remote state. (Possibly those could be separate objects too...)
 * This is our 'model' object if we are thinking MVC. Needs to be better factored, lots of feature envy with the UploadWizard
 * states:
 *   'new' 'transporting' 'transported' 'metadata' 'stashed' 'details' 'submitting-details' 'complete' 'error'

Function getTransformedCanvasElement has 54 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    mw.UploadWizardUpload.prototype.getTransformedCanvasElement = function ( image, constraints ) {
        var angle, scaling, width, height,
            dimensions, dx, dy, x, y, $canvas, ctx,
            scaleConstraints = constraints,
            rotation = 0;

Function makePreview has 49 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    mw.UploadWizardUpload.prototype.makePreview = function ( width ) {
        var first, video, url, dataUrlReader,
            deferred = $.Deferred(),
            upload = this;

Function getImageInfo has 45 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    mw.UploadWizardUpload.prototype.getImageInfo = function ( callback, props, width, height ) {
        var requestedTitle, params;

        function ok( data ) {
            var found;

Function getApiThumbnail has 43 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    mw.UploadWizardUpload.prototype.getApiThumbnail = function ( width, height ) {
        var deferred = $.Deferred();

        function thumbnailPublisher( thumbnails ) {
            if ( thumbnails === null ) {

Function extractMetadataFromJpegMeta has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    mw.UploadWizardUpload.prototype.extractMetadataFromJpegMeta = function () {
        var binReader, jpegmeta,
            deferred = $.Deferred(),
            upload = this;
        if ( this.file && this.file.type === 'image/jpeg' ) {

Function thumbnailPublisher has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        function thumbnailPublisher( thumbnails ) {
            if ( thumbnails === null ) {
                // the api call failed somehow, no thumbnail data.
                deferred.resolve( null );
            } else {

Function getStashImageInfo has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    mw.UploadWizardUpload.prototype.getStashImageInfo = function ( callback, props, width, height ) {
        var params = {
            prop: 'stashimageinfo',
            siifilekey: this.fileKey,
            siiprop: props.join( '|' )

Function getThumbnail has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    mw.UploadWizardUpload.prototype.getThumbnail = function ( width, height ) {
        var upload = this,
            deferred = $.Deferred();

        if ( this.thumbnailPromise[ width + 'x' + height ] ) {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if ( width !== undefined || height !== undefined ) {
            if ( props.indexOf( 'url' ) === -1 ) {
                props.push( 'url' );
            }
            if ( width !== undefined ) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if ( width !== undefined || height !== undefined ) {
            if ( props.indexOf( 'url' ) === -1 ) {
                props.push( 'url' );
            }
            if ( width !== undefined ) {

• Read up
  Read up