Sign upLogin

wikimedia/mediawiki-extensions-UploadWizard

View on GitHub
Star
resources/uw.LicenseGroup.js

Summary

Maintainability
C
7 hrs
Test Coverage

File uw.LicenseGroup.js has 281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

( function ( uw ) {

    /**
     * @extends OO.ui.LicenseGroup
     *
Severity: Minor
Found in resources/uw.LicenseGroup.js - About 2 hrs to fix

    Function createLabel has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        uw.LicenseGroup.prototype.createLabel = function ( name ) {
        var licenseInfo = this.getLicenseInfo( name ),
            messageKey = licenseInfo.props.msg === undefined ?
                '[missing msg for ' + licenseInfo.name + ']' :
                licenseInfo.props.msg,
    Severity: Minor
    Found in resources/uw.LicenseGroup.js - About 1 hr to fix

      Function UWLicenseGroup has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          uw.LicenseGroup = function UWLicenseGroup( config, type, api, count ) {
        var self = this;

        uw.LicenseGroup.super.call( this, {} );
      Severity: Minor
      Found in resources/uw.LicenseGroup.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if ( this.type === 'radio' ) {
            this.group = this.createRadioGroup( [ 'mwe-upwiz-deed-license-group-body' ] );
            this.group.connect( this, { choose: [ 'emit', 'change', this ] } );
        } else if ( this.type === 'checkbox' ) {
            this.group = this.createCheckboxGroup( [ 'mwe-upwiz-deed-license-group-body' ] );
        Severity: Minor
        Found in resources/uw.LicenseGroup.js and 1 other location - About 50 mins to fix
        resources/uw.LicenseGroup.js on lines 48..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                } else if ( this.type === 'checkbox' ) {
            this.group = this.createCheckboxGroup( [ 'mwe-upwiz-deed-license-group-body' ] );
            this.group.connect( this, { select: [ 'emit', 'change', this ] } );
        }
        Severity: Minor
        Found in resources/uw.LicenseGroup.js and 1 other location - About 50 mins to fix
        resources/uw.LicenseGroup.js on lines 45..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status