Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js

Summary

Maintainability
F
1 wk
Test Coverage

Function _create has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        _create: function () {
            var self = this;

            PARENT.prototype._create.call( this );
Severity: Minor
Found in client/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js - About 1 hr to fix

    Function show has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            show: function () {
            var self = this;

            // eslint-disable-next-line no-jquery/no-sizzle
            if ( this._tipsy.$tip && this._tipsy.$tip.is( ':visible' ) ) {
    Severity: Minor
    Found in client/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              show: function () {
            var self = this;

            // eslint-disable-next-line no-jquery/no-sizzle
            if ( this._tipsy.$tip && this._tipsy.$tip.is( ':visible' ) ) {
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js and 1 other location - About 3 days to fix
      view/resources/jquery/wikibase/jquery.wikibase.wbtooltip.js on lines 186..259

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 674.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              _create: function () {
            var self = this;

            PARENT.prototype._create.call( this );
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js and 1 other location - About 3 days to fix
      view/resources/jquery/wikibase/jquery.wikibase.wbtooltip.js on lines 58..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 632.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              destroy: function () {
            this._tipsy.tip().remove();
            this.element.off( 'mouseenter.' + this.widgetName + ' mouseleave.' + this.widgetName );
            this.element.removeData( 'tipsy' );
            this._tipsy = null;
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js and 1 other location - About 6 hrs to fix
      view/resources/jquery/wikibase/jquery.wikibase.wbtooltip.js on lines 134..146

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 168.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              hide: function () {
            // eslint-disable-next-line no-jquery/no-sizzle
            if ( !this._tipsy || !this._tipsy.$tip || !this._tipsy.$tip.is( ':visible' ) ) {
                return;
            }
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js and 1 other location - About 4 hrs to fix
      view/resources/jquery/wikibase/jquery.wikibase.wbtooltip.js on lines 266..278

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 125.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              _evaluateGravity: function ( gravity ) {
            if ( document.documentElement.dir === 'rtl' ) {
                if ( gravity.search( /e/ ) !== -1 ) {
                    gravity = gravity.replace( /e/g, 'w' );
                } else {
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js and 1 other location - About 2 hrs to fix
      view/resources/jquery/wikibase/jquery.wikibase.wbtooltip.js on lines 172..181

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              degrade: function ( remove ) {
            var self = this;

            this.element.one( 'wbtooltipafterhide', function ( event ) {
                self.destroy();
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js and 1 other location - About 2 hrs to fix
      view/resources/jquery/wikibase/jquery.wikibase.wbtooltip.js on lines 153..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 83.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              option: function ( key, value ) {
            if ( key === 'gravity' ) {
                // Consider language direction:
                value = this._evaluateGravity( value );
            }
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js and 1 other location - About 1 hr to fix
      view/resources/jquery/wikibase/jquery.wikibase.wbtooltip.js on lines 295..301

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status