wikimedia/mediawiki-extensions-Wikibase

View on GitHub

Showing 1,432 of 2,096 total issues

Method __construct has 16 arguments (exceeds 4 allowed). Consider refactoring.
Open

        DispatchingEntityViewFactory $entityViewFactory,
        DispatchingEntityMetaTagsCreatorFactory $entityMetaTagsCreatorFactory,
        EntityTitleLookup $entityTitleLookup,
        LanguageFallbackChainFactory $languageFallbackChainFactory,
        EntityDataFormatProvider $entityDataFormatProvider,
Severity: Major
Found in repo/includes/ParserOutput/EntityParserOutputGeneratorFactory.php - About 2 hrs to fix

    Method handleChange has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function handleChange( EntityChange $change, array $rootJobParams = [] ) {
            $changeId = $this->getChangeIdForLog( $change );
    
            $this->logger->debug(
                '{method}: handling change #{changeId} ({changeType})',
    Severity: Minor
    Found in client/includes/Changes/ChangeHandler.php - About 1 hr to fix

      Method __construct has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct() {
              parent::__construct();
      
              $this->addDescription( 'Populates Wikibase db with randomly generated entities and terms' );
      
      
      Severity: Minor
      Found in repo/maintenance/populateWithRandomEntitiesAndTerms.php - About 1 hr to fix

        Method execute has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function execute() {
                //TODO: more validation for options
                $shardingFactor = (int)$this->getOption( 'sharding-factor', 1 );
                $shard = (int)$this->getOption( 'shard', 0 );
                $batchSize = (int)$this->getOption( 'batch-size', 100 );
        Severity: Minor
        Found in repo/maintenance/DumpEntities.php - About 1 hr to fix

          Function tipsy has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              $.fn.tipsy = function(options) {
          
                  if (options === true) {
                      return this.data('tipsy');
                  } else if (typeof options == 'string') {
          Severity: Minor
          Found in view/resources/jquery/wikibase/jquery.tipsy/jquery.tipsy.js - About 1 hr to fix

            Function tipsy has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                $.fn.tipsy = function(options) {
            
                    if (options === true) {
                        return this.data('tipsy');
                    } else if (typeof options == 'string') {
            Severity: Minor
            Found in client/resources/jquery.wikibase/jquery.tipsy/jquery.tipsy.js - About 1 hr to fix

              Method addStatement has 48 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function addStatement( EntityId $entityId, Statement $statement, $isBest ) {
                      $statementLName = $this->vocabulary->getStatementLName( $statement );
              
                      $entityRepository = $this->vocabulary->getEntityRepositoryName( $entityId );
              
              
              Severity: Minor
              Found in repo/includes/Rdf/FullStatementRdfBuilder.php - About 1 hr to fix

                Method onResourceLoaderRegisterModules has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function onResourceLoaderRegisterModules( ResourceLoader $rl ): void {
                        $moduleTemplate = [
                            'localBasePath' => __DIR__ . '/..',
                            'remoteExtPath' => 'Wikibase/view',
                        ];
                Severity: Minor
                Found in view/src/ViewHooks.php - About 1 hr to fix

                  Function 9bf2 has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                  /***/ (function(module, exports, __webpack_require__) {
                  
                  var DESCRIPTORS = __webpack_require__("83ab");
                  var IE8_DOM_DEFINE = __webpack_require__("0cfb");
                  var anObject = __webpack_require__("825a");
                  Severity: Minor
                  Found in view/lib/wikibase-tainted-ref/dist/tainted-ref.common.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function showUndoForm has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function showUndoForm(): void {
                          $this->getOutput()->enableOOUI();
                          $req = $this->getRequest();
                  
                          if ( $this->showPermissionError( 'read' ) || $this->showPermissionError( 'edit' ) ) {
                  Severity: Minor
                  Found in repo/includes/Actions/EditEntityAction.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function execute has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function execute( $subPage ) {
                          parent::execute( $subPage );
                  
                          // Setup
                          $request = $this->getRequest();
                  Severity: Minor
                  Found in repo/includes/Specials/SpecialItemByTitle.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function cleanTermInLangIds has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function cleanTermInLangIds( array $termInLangIds ) {
                          $termInLangIdsAsKeys = array_flip( $termInLangIds );
                          foreach ( $this->terms as $type => &$termsOfType ) {
                              foreach ( $termsOfType as $lang => &$termsOfLang ) {
                                  foreach ( $termsOfLang as $term => $id ) {
                  Severity: Minor
                  Found in lib/includes/Store/Sql/Terms/InMemoryTermStore.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function fetchResults has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      function fetchResults( q, batchSize, offset = null ) {
                          const api = new mw.Api();
                          const data = {
                              action: 'wbsearchentities',
                              search: q,
                  Severity: Minor
                  Found in repo/resources/wikibase.vector.searchClient.js - About 1 hr to fix

                    Method prepareChangeAttributes has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function prepareChangeAttributes( EntityChange $change ) {
                            $rcinfo = $change->getMetadata();
                    
                            $fields = $change->getFields();
                            $fields['entity_type'] = $change->getEntityId()->getEntityType();
                    Severity: Minor
                    Found in client/includes/RecentChanges/RecentChangeFactory.php - About 1 hr to fix

                      Method getForm has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function getForm( EntityDocument $entity = null ) {
                              if ( $this->isEditFormStep( $entity ) ) {
                      
                                  $languageName = $this->languageNameUtils->getLanguageName(
                                      $this->languageCode, $this->getLanguage()->getCode()
                      Severity: Minor
                      Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php - About 1 hr to fix

                        Method executeInternal has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function executeInternal(): void {
                                $this->getMain()->setCacheMode( 'public' );
                        
                                $params = $this->extractRequestParams();
                        
                        
                        Severity: Minor
                        Found in repo/includes/Api/SearchEntities.php - About 1 hr to fix

                          Method run has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function run( $new, IContextSource $context, string $summary ) {
                                  $filterStatus = Status::newGood();
                          
                                  if ( !$this->hookContainer->isRegistered( 'EditFilterMergedContent' ) ) {
                                      return $filterStatus;
                          Severity: Minor
                          Found in repo/includes/EditEntity/MediaWikiEditFilterHookRunner.php - About 1 hr to fix

                            Function SELF has 15 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                        toolbarFactory,
                                        entityChangersFactory,
                                        structureEditorFactory,
                                        contentLanguages,
                                        dataTypeStore,
                            Severity: Major
                            Found in view/resources/wikibase/view/ControllerViewFactory.js - About 1 hr to fix

                              Method __construct has 15 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      EntityTitleStoreLookup $titleLookup,
                                      EntityRevisionLookup $entityLookup,
                                      EntityStore $entityStore,
                                      EntityPermissionChecker $permissionChecker,
                                      EntityDiffer $entityDiffer,
                              Severity: Major
                              Found in repo/includes/EditEntity/MediaWikiEditEntity.php - About 1 hr to fix

                                Function _create has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                        _create: function () {
                                            var self = this;
                                
                                            PARENT.prototype._create.call( this );
                                
                                
                                Severity: Minor
                                Found in client/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js - About 1 hr to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language