wikimedia/mediawiki-extensions-Wikibase

View on GitHub

Showing 1,432 of 2,096 total issues

Method prefetchCachedTerms has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function prefetchCachedTerms( array $entityIds, array $termTypes, array $languageCodes ): array {
        [
            self::RESOLVED_KEYS => $cacheKeys,
            self::UNRESOLVED_IDS => $unresolvedIds, // This is intentionally unused.
            self::KEY_PARTS_MAP => $keyPartsMap,
Severity: Minor
Found in lib/includes/Store/CachingPrefetchingTermLookup.php - About 1 hr to fix

    Method parseWellKnownProperty has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function parseWellKnownProperty(
            array $wellKnownPropertyIds,
            string $wellKnownName,
            LoggerInterface $logger
        ): ?NumericPropertyId {
    Severity: Minor
    Found in lib/includes/Formatters/Reference/WellKnownReferenceProperties.php - About 1 hr to fix

      Function getPermissionErrors has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public async getPermissionErrors( title: string ): Promise<PermissionError[]> {
              const response = await this.api.get( {
                  action: 'query',
                  titles: new Set( [ title ] ),
                  prop: new Set( [ 'info' ] ),

        Function SELF has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                expertStore,
                formatterFactory,
                parserStore,
                language,
                messageProvider,
        Severity: Major
        Found in view/resources/wikibase/wikibase.ValueViewBuilder.js - About 1 hr to fix

          Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  AffectedPagesFinder $affectedPagesFinder,
                  TitleFactory $titleFactory,
                  PageStore $pageStore,
                  PageUpdater $updater,
                  ChangeRunCoalescer $changeRunCoalescer,
          Severity: Major
          Found in client/includes/Changes/ChangeHandler.php - About 1 hr to fix

            Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    PropertyLabelResolver $propertyLabelResolver,
                    SnaksFinder $snaksFinder,
                    EntityLookup $entityLookup,
                    DataAccessSnakFormatterFactory $dataAccessSnakFormatterFactory,
                    UsageAccumulatorFactory $usageAccumulatorFactory,

              Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      NamespaceChecker $namespaceChecker,
                      JobQueueGroupFactory $jobQueueGroupFactory,
                      DatabaseEntitySource $entitySource,
                      SiteLinkLookup $siteLinkLookup,
                      LoggerInterface $logger,
              Severity: Major
              Found in client/includes/Hooks/UpdateRepoHookHandler.php - About 1 hr to fix

                Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        PropertyTermStoreWriter $propertyTermStoreWriter,
                        SeekableEntityIdPager $idPager,
                        MessageReporter $progressReporter,
                        MessageReporter $errorReporter,
                        RepoDomainDb $db,
                Severity: Major
                Found in repo/includes/Store/PropertyTermsRebuilder.php - About 1 hr to fix

                  Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          SubscriptionLookup $subscriptionLookup,
                          EntityChangeLookup $changeLookup,
                          EntityIdParser $entityIdParser,
                          JobQueueGroupFactory $jobQueueGroupFactory,
                          ChangeStore $changeStore,
                  Severity: Major
                  Found in repo/includes/ChangeModification/DispatchChangesJob.php - About 1 hr to fix

                    Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            ItemTermStoreWriter $itemTermStoreWriter,
                            $itemIdIterable,
                            MessageReporter $progressReporter,
                            MessageReporter $errorReporter,
                            RepoDomainDb $db,
                    Severity: Major
                    Found in repo/includes/Store/ItemTermsRebuilder.php - About 1 hr to fix

                      Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              Config $config = null,
                              LoggerInterface $logger = null,
                              ExtensionRegistry $extensionRegistry = null,
                              SettingsArray $wikibaseRepoSettings = null,
                              HTTPRequestFactory $requestFactory = null,
                      Severity: Major
                      Found in repo/includes/WikibasePingback.php - About 1 hr to fix

                        Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                EntityRevisionLookup $entityRevisionLookup,
                                EntityStore $entityStore,
                                EntityPermissionChecker $permissionChecker,
                                SummaryFormatter $summaryFormatter,
                                EditFilterHookRunner $editFilterHookRunner,
                        Severity: Major
                        Found in repo/includes/Interactors/EntityRedirectCreationInteractor.php - About 1 hr to fix

                          Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  ApiResult $result,
                                  EntityTitleStoreLookup $entityTitleStoreLookup,
                                  SerializerFactory $serializerFactory,
                                  Serializer $entitySerializer,
                                  SiteLookup $siteLookup,
                          Severity: Major
                          Found in repo/includes/Api/ResultBuilder.php - About 1 hr to fix

                            Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    MergeFactory $mergeFactory,
                                    EntityRevisionLookup $entityRevisionLookup,
                                    MediaWikiEditEntityFactory $editEntityFactory,
                                    EntityPermissionChecker $permissionChecker,
                                    SummaryFormatter $summaryFormatter,
                            Severity: Major
                            Found in repo/includes/Interactors/ItemMergeInteractor.php - About 1 hr to fix

                              Method factory has 8 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      ApiMain $mainModule,
                                      string $moduleName,
                                      ApiHelperFactory $apiHelperFactory,
                                      ChangeOpFactoryProvider $changeOpFactoryProvider,
                                      EntityIdParser $entityIdParser,
                              Severity: Major
                              Found in repo/includes/Api/CreateClaim.php - About 1 hr to fix

                                Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                        ApiMain $mainModule,
                                        string $moduleName,
                                        SiteLinkChangeOpFactory $siteLinkChangeOpFactory,
                                        SiteLinkBadgeChangeOpSerializationValidator $badgeSerializationValidator,
                                        SiteLinkPageNormalizer $siteLinkPageNormalizer,
                                Severity: Major
                                Found in repo/includes/Api/SetSiteLink.php - About 1 hr to fix

                                  Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                          ApiQuery $apiQuery,
                                          string $moduleName,
                                          LinkBatchFactory $linkBatchFactory,
                                          EntitySearchHelper $entitySearchHelper,
                                          EntityTitleLookup $titleLookup,
                                  Severity: Major
                                  Found in repo/includes/Api/QuerySearchEntities.php - About 1 hr to fix

                                    Method factory has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                            ApiQuery $apiQuery,
                                            string $moduleName,
                                            LinkBatchFactory $linkBatchFactory,
                                            array $enabledEntityTypes,
                                            array $entitySearchHelperCallbacks,
                                    Severity: Major
                                    Found in repo/includes/Api/QuerySearchEntities.php - About 1 hr to fix

                                      Method factory has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                              ApiMain $mainModule,
                                              string $moduleName,
                                              IBufferingStatsdDataFactory $statsdDataFactory,
                                              DataTypeDefinitions $dataTypeDefinitions,
                                              EntityChangeOpProvider $entityChangeOpProvider,
                                      Severity: Major
                                      Found in repo/includes/Api/EditEntity.php - About 1 hr to fix

                                        Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                                ApiMain $mainModule,
                                                string $moduleName,
                                                StatementGuidValidator $guidValidator,
                                                StatementGuidParser $guidParser,
                                                EntityIdParser $idParser,
                                        Severity: Major
                                        Found in repo/includes/Api/GetClaims.php - About 1 hr to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language