wikimedia/mediawiki-extensions-Wikibase

View on GitHub

Showing 1,432 of 2,096 total issues

File SetClaim.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare( strict_types = 1 );

namespace Wikibase\Repo\Api;
Severity: Minor
Found in repo/includes/Api/SetClaim.php - About 2 hrs to fix

    Function 69f3 has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    /***/ (function(module, exports, __webpack_require__) {
    
    var NATIVE_WEAK_MAP = __webpack_require__("7f9a");
    var global = __webpack_require__("da84");
    var isObject = __webpack_require__("861d");
    Severity: Major
    Found in view/lib/wikibase-tainted-ref/dist/tainted-ref.common.js - About 2 hrs to fix

      Method undo has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function undo(): void {
              $request = $this->getRequest();
              $undidRevId = $request->getInt( 'undo' );
              $undidAfterRevId = $request->getInt( 'undoafter' );
              $restoreId = $request->getInt( 'restore' );
      Severity: Major
      Found in repo/includes/Actions/SubmitEntityAction.php - About 2 hrs to fix

        Function saveBridge has 59 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public async saveBridge(): Promise<unknown> {
                if ( this.state.applicationStatus !== ApplicationStatus.READY ) {
                    this.commit( 'addApplicationErrors', [ {
                        type: ErrorTypes.APPLICATION_LOGIC_ERROR,
                        info: { stack: ( new Error() ).stack },
        Severity: Major
        Found in client/data-bridge/src/store/actions.ts - About 2 hrs to fix

          File DatabaseTermInLangIdsAcquirer.php has 264 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          
          namespace Wikibase\Lib\Store\Sql\Terms;
          
          use MediaWiki\MediaWikiServices;
          Severity: Minor
          Found in lib/includes/Store/Sql/Terms/DatabaseTermInLangIdsAcquirer.php - About 2 hrs to fix

            ChangeLineFormatter has 22 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class ChangeLineFormatter {
            
                /**
                 * @var RepoLinker
                 */
            Severity: Minor
            Found in client/includes/RecentChanges/ChangeLineFormatter.php - About 2 hrs to fix

              Property has 22 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Property implements
                  StatementListProvidingEntity,
                  FingerprintProvider,
                  StatementListHolder,
                  LabelsProvider,
              Severity: Minor
              Found in lib/packages/wikibase/data-model/src/Entity/Property.php - About 2 hrs to fix

                Function _initMenu has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        _initMenu: function ( ooMenu ) {
                            var self = this;
                            $.ui.suggester.prototype._initMenu.apply( this, arguments );
                
                            $( this.options.menu )
                Severity: Major
                Found in view/resources/jquery/wikibase/jquery.wikibase.entityselector.js - About 2 hrs to fix

                  Method getForm has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function getForm( EntityDocument $entity = null ) {
                          if ( $this->languageCode === null ) {
                              $this->languageCode = $this->getLanguage()->getCode();
                          }
                  
                  
                  Severity: Major
                  Found in repo/includes/Specials/SpecialModifyTerm.php - About 2 hrs to fix

                    Method onResourceLoaderRegisterModules has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static function onResourceLoaderRegisterModules( ResourceLoader $resourceLoader ) {
                            $moduleTemplate = [
                                'localBasePath' => __DIR__ . '/..',
                                'remoteExtPath' => 'Wikibase/repo',
                            ];
                    Severity: Major
                    Found in repo/includes/RepoHooks.php - About 2 hrs to fix

                      File SubmitEntityAction.php has 263 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php
                      
                      declare( strict_types = 1 );
                      
                      namespace Wikibase\Repo\Actions;
                      Severity: Minor
                      Found in repo/includes/Actions/SubmitEntityAction.php - About 2 hrs to fix

                        Function save has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                save: function ( newFingerprint, oldFingerprint ) {
                                    var labelsChanger = this._labelsChanger,
                                        descriptionsChanger = this._descriptionsChanger,
                                        aliasesChanger = this._aliasesChanger,
                                        changes = [],
                        Severity: Major
                        Found in view/resources/wikibase/entityChangers/EntityTermsChanger.js - About 2 hrs to fix

                          Method coalesceRuns has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              private function coalesceRuns( EntityId $entityId, array $changes ) {
                                  $coalesced = [];
                          
                                  $currentRun = [];
                                  $currentUser = null;
                          Severity: Major
                          Found in client/includes/Changes/ChangeRunCoalescer.php - About 2 hrs to fix

                            Method loadEntity has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function loadEntity( array $requestParams, ?EntityId $entityId = null, $assignFreshId = self::ASSIGN_FRESH_ID ): EntityDocument {
                                    if ( !in_array( $assignFreshId, [ self::ASSIGN_FRESH_ID, self::NO_FRESH_ID ] ) ) {
                                        throw new InvalidArgumentException(
                                            '$assignFreshId must be either of the EntitySavingHelper::ASSIGN_FRESH_ID/NO_FRESH_ID constants.'
                                        );
                            Severity: Major
                            Found in repo/includes/Api/EntitySavingHelper.php - About 2 hrs to fix

                              Method execute has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function execute(): void {
                                      $lookup = $this->revisionLookup;
                              
                                      $params = $this->extractRequestParams();
                                      $this->validateParameters( $params );
                              Severity: Major
                              Found in repo/includes/Api/LinkTitles.php - About 2 hrs to fix

                                Function actions has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                export default function actions( metricTracker: TrackFunction ): ActionTree<Application, Application> {
                                    return {
                                        [ STORE_INIT ](
                                            context: ActionContext<Application, Application>,
                                            guids: string[],
                                Severity: Major
                                Found in view/lib/wikibase-tainted-ref/src/store/actions.ts - About 2 hrs to fix

                                  Function undo has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      public function undo(): void {
                                          $request = $this->getRequest();
                                          $undidRevId = $request->getInt( 'undo' );
                                          $undidAfterRevId = $request->getInt( 'undoafter' );
                                          $restoreId = $request->getInt( 'restore' );
                                  Severity: Minor
                                  Found in repo/includes/Actions/SubmitEntityAction.php - About 2 hrs to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Function getRankedSearchResults has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      public function getRankedSearchResults(
                                          $text,
                                          $languageCode,
                                          $entityType,
                                          $limit,
                                  Severity: Minor
                                  Found in repo/includes/FederatedProperties/ApiEntitySearchHelper.php - About 2 hrs to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Function onApiCheckCanExecute has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      public static function onApiCheckCanExecute( ApiBase $module, User $user, &$message ) {
                                          if ( $module instanceof ApiEditPage ) {
                                              $params = $module->extractRequestParams();
                                              $pageObj = $module->getTitleOrPageId( $params );
                                              $namespace = $pageObj->getTitle()->getNamespace();
                                  Severity: Minor
                                  Found in repo/includes/RepoHooks.php - About 2 hrs to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Function initialize has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                          LeavingSiteNoticeDialog.prototype.initialize = function () {
                                              LeavingSiteNoticeDialog.super.prototype.initialize.apply( this, arguments );
                                              var dialog = this;
                                  
                                              var inputCheckbox = new OO.ui.CheckboxInputWidget( {
                                  Severity: Major
                                  Found in repo/resources/wikibase.federatedPropertiesLeavingSiteNotice.js - About 2 hrs to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language