wikimedia/mediawiki-extensions-Wikibase

View on GitHub
repo/resources/wikibase.ui.entityViewInit.js

Summary

Maintainability
D
2 days
Test Coverage

File wikibase.ui.entityViewInit.js has 350 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @license GPL-2.0-or-later
 * @author H. Snater < mediawiki@snater.com >
 * @author Daniel Werner < daniel.a.r.werner@gmail.com >
 * @author Adrian Heine <adrian.heine@wikimedia.de>
Severity: Minor
Found in repo/resources/wikibase.ui.entityViewInit.js - About 4 hrs to fix

    Function showCopyrightTooltip has 101 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function showCopyrightTooltip( $entityview, $origin, gravity, viewName ) {
            if ( !mw.config.exists( 'wbCopyright' ) ) {
                return;
            }
    
    
    Severity: Major
    Found in repo/resources/wikibase.ui.entityViewInit.js - About 4 hrs to fix

      Function createEntityView has 82 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function createEntityView( entity, $entityview ) {
              var currentRevision, revisionStore, entityChangersFactory,
                  viewFactoryArguments, ViewFactoryFactory, viewFactory, entityView,
                  repoConfig = mw.config.get( 'wbRepo' ),
                  repoApiUrl = repoConfig.url + repoConfig.scriptPath + '/api.php',
      Severity: Major
      Found in repo/resources/wikibase.ui.entityViewInit.js - About 3 hrs to fix

        Function attachWatchLinkUpdater has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function attachWatchLinkUpdater( $entityview, viewName ) {
                var update;
        
                if ( mw.loader.getState( 'mediawiki.page.watch.ajax' ) !== 'ready' || !mw.user.options.get( 'watchdefault' ) ) {
                    return;
        Severity: Minor
        Found in repo/resources/wikibase.ui.entityViewInit.js - About 1 hr to fix

          Function attachCopyrightTooltip has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function attachCopyrightTooltip( $entityview, viewName ) {
                  var startEditingEvents = [
                      'entitytermsviewafterstartediting',
                      'sitelinkgroupviewafterstartediting',
                      'statementviewafterstartediting'
          Severity: Minor
          Found in repo/resources/wikibase.ui.entityViewInit.js - About 1 hr to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        if ( mw.user.isAnon() ) {
                            mw.cookie.set( cookieKey, copyRightVersion, { expires: 3 * 365 * 24 * 60 * 60, path: '/' } );
                        } else {
                            var api = new mw.Api();
                            api.saveOption( optionsKey, copyRightVersion );
            Severity: Major
            Found in repo/resources/wikibase.ui.entityViewInit.js and 2 other locations - About 2 hrs to fix
            repo/resources/wikibase.federatedPropertiesLeavingSiteNotice.js on lines 58..63
            repo/resources/wikibase.ui.entityViewInit.js on lines 269..274

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 92.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            if ( mw.user.isAnon() ) {
                                mw.cookie.set( cookieKey, copyRightVersion, { expires: 3 * 365 * 24 * 60 * 60, path: '/' } );
                            } else {
                                var api = new mw.Api();
                                api.saveOption( optionsKey, copyRightVersion );
            Severity: Major
            Found in repo/resources/wikibase.ui.entityViewInit.js and 2 other locations - About 2 hrs to fix
            repo/resources/wikibase.federatedPropertiesLeavingSiteNotice.js on lines 58..63
            repo/resources/wikibase.ui.entityViewInit.js on lines 315..320

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 92.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status