Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
view/resources/jquery/wikibase/jquery.wikibase.descriptionview.js

Summary

Maintainability
F
3 days
Test Coverage

Function draw has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        draw: function () {
            var done = $.Deferred().resolve().promise();
            var self = this,
                languageCode = this.options.value.getLanguageCode(),
                descriptionText = this.options.value.getText();
Severity: Major
Found in view/resources/jquery/wikibase/jquery.wikibase.descriptionview.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            _create: function () {
            if ( !( this.options.value instanceof datamodel.Term )
                || this.options.inputNodeName !== 'INPUT' && this.options.inputNodeName !== 'TEXTAREA'
            ) {
                throw new Error( 'Required parameter(s) missing' );
    Severity: Major
    Found in view/resources/jquery/wikibase/jquery.wikibase.descriptionview.js and 1 other location - About 1 day to fix
    view/resources/jquery/wikibase/jquery.wikibase.labelview.js on lines 53..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 237.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            _setOption: function ( key, value ) {
            if ( key === 'value' && !( value instanceof datamodel.Term ) ) {
                throw new Error( 'Value needs to be a datamodel.Term instance' );
            }
    Severity: Major
    Found in view/resources/jquery/wikibase/jquery.wikibase.descriptionview.js and 1 other location - About 4 hrs to fix
    view/resources/jquery/wikibase/jquery.wikibase.labelview.js on lines 239..251

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 132.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            value: function ( value ) {
            if ( value !== undefined ) {
                return this.option( 'value', value );
            }
    Severity: Major
    Found in view/resources/jquery/wikibase/jquery.wikibase.descriptionview.js and 1 other location - About 4 hrs to fix
    view/resources/jquery/wikibase/jquery.wikibase.labelview.js on lines 259..272

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 128.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            destroy: function () {
            if ( this.isInEditMode() ) {
                var self = this;

                this.element.one( this.widgetEventPrefix + 'afterstopediting', function ( event ) {
    Severity: Major
    Found in view/resources/jquery/wikibase/jquery.wikibase.descriptionview.js and 1 other location - About 4 hrs to fix
    view/resources/jquery/wikibase/jquery.wikibase.labelview.js on lines 90..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 116.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            focus: function () {
            if ( this.isInEditMode() ) {
                this.$text.children( '.' + this.widgetFullName + '-input' ).trigger( 'focus' );
            } else {
                this.element.trigger( 'focus' );
    Severity: Major
    Found in view/resources/jquery/wikibase/jquery.wikibase.descriptionview.js and 1 other location - About 2 hrs to fix
    view/resources/jquery/wikibase/jquery.wikibase.labelview.js on lines 277..283

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                $input
            .addClass( this.widgetFullName + '-input' )
            .attr( 'placeholder', mw.msg(
                // The following messages can be used here:
                // * wikibase-description-edit-placeholder-language-aware
    Severity: Minor
    Found in view/resources/jquery/wikibase/jquery.wikibase.descriptionview.js and 1 other location - About 55 mins to fix
    view/resources/jquery/wikibase/jquery.wikibase.labelview.js on lines 188..198

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status