wikimedia/mediawiki-extensions-Wikibase

View on GitHub
view/resources/jquery/wikibase/jquery.wikibase.entityselector.js

Summary

Maintainability
D
1 day
Test Coverage

File jquery.wikibase.entityselector.js has 441 lines of code (exceeds 250 allowed). Consider refactoring.
Open

( function () {
    'use strict';

    // TODO: Get rid of MediaWiki context detection by submitting a message provider as option.

Severity: Minor
Found in view/resources/jquery/wikibase/jquery.wikibase.entityselector.js - About 6 hrs to fix

    Function _initMenu has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _initMenu: function ( ooMenu ) {
                var self = this;
                $.ui.suggester.prototype._initMenu.apply( this, arguments );
    
                $( this.options.menu )
    Severity: Major
    Found in view/resources/jquery/wikibase/jquery.wikibase.entityselector.js - About 2 hrs to fix

      Function _initDefaultSource has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              _initDefaultSource: function () {
                  var self = this;
      
                  return function ( term ) {
                      var deferred = $.Deferred(),
      Severity: Minor
      Found in view/resources/jquery/wikibase/jquery.wikibase.entityselector.js - About 1 hr to fix

        Function _combineResults has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                _combineResults: function ( hookResults, searchResults ) {
                    var self = this,
                        deferred = $.Deferred(),
                        ids = {},
                        result = [],
        Severity: Minor
        Found in view/resources/jquery/wikibase/jquery.wikibase.entityselector.js - About 1 hr to fix

          Function _create has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  _create: function () {
                      var self = this;
          
                      this._cache = {};
          
          
          Severity: Minor
          Found in view/resources/jquery/wikibase/jquery.wikibase.entityselector.js - About 1 hr to fix

            Avoid too many return statements within this function.
            Open

                                return -1;
            Severity: Major
            Found in view/resources/jquery/wikibase/jquery.wikibase.entityselector.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                                      return 0;
              Severity: Major
              Found in view/resources/jquery/wikibase/jquery.wikibase.entityselector.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    Item = util.inherit(
                        $.ui.ooMenu.Item,
                        Item,
                        {
                            /**
                view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 354..370

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 56.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status