Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
view/resources/jquery/wikibase/jquery.wikibase.entitytermsview.js

Summary

Maintainability
C
1 day
Test Coverage

File jquery.wikibase.entitytermsview.js has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @license GPL-2.0-or-later
 * @author H. Snater < mediawiki@snater.com >
 */
( function ( wb ) {
Severity: Minor
Found in view/resources/jquery/wikibase/jquery.wikibase.entitytermsview.js - About 3 hrs to fix

    Function _create has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _create: function () {
            if ( !( this.options.value instanceof datamodel.Fingerprint )
                || !Array.isArray( this.options.userLanguages )
            ) {
                throw new Error( 'Required option(s) missing' );
    Severity: Minor
    Found in view/resources/jquery/wikibase/jquery.wikibase.entitytermsview.js - About 2 hrs to fix

      Function _registerTogglerForLanguagelistviewDiv has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              _registerTogglerForLanguagelistviewDiv: function ( optionKey ) {
            var self = this,
                api = new mw.Api();
            this.$entitytermsforlanguagelistviewToggler = $( '<div>' )
                .addClass( 'wikibase-entitytermsview-entitytermsforlanguagelistview-toggler' )
      Severity: Minor
      Found in view/resources/jquery/wikibase/jquery.wikibase.entitytermsview.js - About 1 hr to fix

        Function _createEntitytermsforlanguagelistviewToggler has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                _createEntitytermsforlanguagelistviewToggler: function () {
            this._registerTogglerForLanguagelistviewDiv( TOGGLER_OPTION_KEY );

            this.$entitytermsforlanguagelistviewContainer.before(
                this.$entitytermsforlanguagelistviewToggler
        Severity: Minor
        Found in view/resources/jquery/wikibase/jquery.wikibase.entitytermsview.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      this.$entitytermsforlanguagelistview
            .on( prefix + 'change.' + this.widgetName, function ( event, lang ) {
                event.stopPropagation();
                // Event handlers for this are in the entitytermsview toolbar controller (for enabling
                // the save button), in entityViewInit (for updating the title) and in this file (for
          Severity: Major
          Found in view/resources/jquery/wikibase/jquery.wikibase.entitytermsview.js and 1 other location - About 2 hrs to fix
          view/resources/jquery/wikibase/jquery.wikibase.entitytermsforlanguagelistview.js on lines 190..210

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ( !( this.options.value instanceof datamodel.Fingerprint )
                || !Array.isArray( this.options.userLanguages )
            ) {
                throw new Error( 'Required option(s) missing' );
            }
          Severity: Minor
          Found in view/resources/jquery/wikibase/jquery.wikibase.entitytermsview.js and 1 other location - About 55 mins to fix
          view/resources/jquery/wikibase/jquery.wikibase.entitytermsforlanguagelistview.js on lines 89..93

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status