Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js

Summary

Maintainability
C
1 day
Test Coverage

File jquery.wikibase.sitelinklistview.js has 333 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @license GPL-2.0-or-later
 * @author H. Snater < mediawiki@snater.com >
 */
( function ( wb ) {
Severity: Minor
Found in view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js - About 4 hrs to fix

    Function _createListView has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _createListView: function () {
            var self = this,
                listItemAdapter = this.options.getListItemAdapter(
                    function () {
                        return self._getUnusedAllowedSiteIds().map( function ( siteId ) {
    Severity: Major
    Found in view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js - About 2 hrs to fix

      Function focus has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              focus: function () {
            // Focus first invalid/incomplete item or - if there is none - the first item.
            var listview = this.$listview.data( 'listview' ),
                lia = listview.listItemAdapter(),
                $items = listview.items();
      Severity: Minor
      Found in view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            touchesViewportHorizontally = rect.right >= 0 && rect.right < wWidth
                        || rect.left >= 0 && rect.left < wWidth,
        Severity: Minor
        Found in view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js and 1 other location - About 40 mins to fix
        view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js on lines 336..337

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            touchesViewportVertically = rect.top >= 0 && rect.top < wHeight
                        || rect.bottom >= 0 && rect.bottom < wHeight;
        Severity: Minor
        Found in view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js and 1 other location - About 40 mins to fix
        view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js on lines 334..335

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status