wikimedia/mediawiki-extensions-Wikibase

View on GitHub
view/resources/jquery/wikibase/jquery.wikibase.statementview.js

Summary

Maintainability
D
2 days
Test Coverage

File jquery.wikibase.statementview.js has 488 lines of code (exceeds 250 allowed). Consider refactoring.
Open

( function ( wb ) {
    'use strict';

    var PARENT = $.ui.EditableTemplatedWidget,
        datamodel = require( 'wikibase.datamodel' ),
Severity: Minor
Found in view/resources/jquery/wikibase/jquery.wikibase.statementview.js - About 7 hrs to fix

    Function _setOption has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _setOption: function ( key, value ) {
                var response = PARENT.prototype._setOption.apply( this, arguments );
    
                if ( key === 'disabled' ) {
                    if ( this._mainSnakSnakView ) {
    Severity: Minor
    Found in view/resources/jquery/wikibase/jquery.wikibase.statementview.js - About 1 hr to fix

      Function _createReferencesListview has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              _createReferencesListview: function ( references ) {
                  var self = this;
      
                  var $listview = this.$references.children( '.wikibase-listview' );
                  if ( !$listview.length ) {
      Severity: Minor
      Found in view/resources/jquery/wikibase/jquery.wikibase.statementview.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

                    return new datamodel.Statement(
                        new datamodel.Claim( mainSnak, qualifiers, guid ),
                        references,
                        this._rankSelector.value()
                    );
        Severity: Major
        Found in view/resources/jquery/wikibase/jquery.wikibase.statementview.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ( !this._referencesListview.value().every( function ( referenceview ) {
                          var value = referenceview.value();
                          references.push( value );
                          return value;
                      } ) ) {
          view/resources/jquery/wikibase/jquery.wikibase.snaklistview.js on lines 223..229

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  _getRankName: function ( rank ) {
                      for ( var rankName in datamodel.Statement.RANK ) {
                          if ( rank === datamodel.Statement.RANK[ rankName ] ) {
                              return rankName.toLowerCase();
                          }
          view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js on lines 24..32

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ( this._rankSelector ) {
                          this._rankSelector.destroy();
                          this.$rankSelector.off( '.' + this.widgetName );
                          this._rankSelector = null;
                      }
          view/resources/jquery/wikibase/jquery.wikibase.statementview.js on lines 403..407

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ( this._mainSnakSnakView ) {
                          this._mainSnakSnakView.destroy();
                          this.$mainSnak.off( '.' + this.widgetName );
                          this._mainSnakSnakView = null;
                      }
          view/resources/jquery/wikibase/jquery.wikibase.statementview.js on lines 397..401

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status