Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
view/resources/jquery/wikibase/snakview/snakview.js

Summary

Maintainability
D
2 days
Test Coverage

File snakview.js has 502 lines of code (exceeds 250 allowed). Consider refactoring.
Open

( function ( wb, dv ) {
    'use strict';

    // Back-up components already initialized in the namespace to re-apply them after initializing
    // the snakview widget.
Severity: Major
Found in view/resources/jquery/wikibase/snakview/snakview.js - About 1 day to fix

    Function updateVariation has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            updateVariation: function () {
            var value = this.value(),
                propertyId = value ? value.property : null,
                snakType = value ? value.snaktype : null,
                VariationConstructor = snakType ? variations.getVariation( snakType ) : null;
    Severity: Minor
    Found in view/resources/jquery/wikibase/snakview/snakview.js - About 1 hr to fix

      Function _setOption has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              _setOption: function ( key, value ) {
            if ( key === 'value' ) {
                if ( value !== null
                    && !$.isPlainObject( value )
                    && !( value instanceof datamodel.Snak )
      Severity: Minor
      Found in view/resources/jquery/wikibase/snakview/snakview.js - About 1 hr to fix

        Function value has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                value: function ( value ) {
            if ( value !== undefined ) {
                this.option( 'value', value );
                return;
            }
        Severity: Minor
        Found in view/resources/jquery/wikibase/snakview/snakview.js - About 1 hr to fix

          Function drawSnakTypeSelector has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  drawSnakTypeSelector: function () {
            if ( this.options.locked.snaktype && this.$snakTypeSelector.contents().length ) {
                return;
            }
          Severity: Minor
          Found in view/resources/jquery/wikibase/snakview/snakview.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    _getPropertySelector: function () {
            if ( this.$property ) {
                return this.$property.children().first().data( 'entityselector' ) || null;
            }
            return null;
            Severity: Major
            Found in view/resources/jquery/wikibase/snakview/snakview.js and 1 other location - About 1 hr to fix
            view/resources/jquery/wikibase/snakview/snakview.js on lines 402..407

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    _getSnakTypeSelector: function () {
            if ( this.$snakTypeSelector ) {
                return this.$snakTypeSelector.children().first().data( 'snaktypeselector' ) || null;
            }
            return null;
            Severity: Major
            Found in view/resources/jquery/wikibase/snakview/snakview.js and 1 other location - About 1 hr to fix
            view/resources/jquery/wikibase/snakview/snakview.js on lines 387..392

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if ( value.datavalue instanceof dv.DataValue ) {
                value.datavalue = {
                    type: value.datavalue.getType(),
                    value: value.datavalue.toJSON()
                };
            Severity: Minor
            Found in view/resources/jquery/wikibase/snakview/snakview.js and 1 other location - About 40 mins to fix
            view/resources/jquery/wikibase/snakview/snakview.js on lines 577..582

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if ( variationValue.datavalue ) {
                    variationValue.datavalue = {
                        type: variationValue.datavalue.getType(),
                        value: variationValue.datavalue.toJSON()
                    };
            Severity: Minor
            Found in view/resources/jquery/wikibase/snakview/snakview.js and 1 other location - About 40 mins to fix
            view/resources/jquery/wikibase/snakview/snakview.js on lines 482..487

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status