wikimedia/wikimedia-fundraising-dash

View on GitHub
src/components/widgets/totals-earned-chart/totals-earned-chart.js

Summary

Maintainability
F
4 days
Test Coverage

Function TotalsEarnedChartViewModel has 354 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function TotalsEarnedChartViewModel( params ) {

        var self = this,
            timeFormat = 'dddd, MMMM Do YYYY, h:mm:ss a',
            localUtcOffset = moment().utcOffset();
Severity: Major
Found in src/components/widgets/totals-earned-chart/totals-earned-chart.js - About 1 day to fix

    File totals-earned-chart.js has 374 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    define( [
        'knockout',
        'text!components/widgets/totals-earned-chart/totals-earned-chart.html',
        'c3',
        'numeraljs',
    Severity: Minor
    Found in src/components/widgets/totals-earned-chart/totals-earned-chart.js - About 5 hrs to fix

      Function makeHourlyChart has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              self.makeHourlyChart = function ( d /* , i */ ) {
                  var hourlyData = params.sharedContext.dayObj[ d.x + 1 ],
                      hourlyCountArray = [ 'Hourly Count' ],
                      hourlyTotalArray = [ 'Hourly Total' ],
                      j;
      Severity: Major
      Found in src/components/widgets/totals-earned-chart/totals-earned-chart.js - About 3 hrs to fix

        Function makeDailyChart has 66 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                self.makeDailyChart = function ( /* d, i */ ) {
                    return {
                        size: {
                            height: 450,
                            width: window.width
        Severity: Major
        Found in src/components/widgets/totals-earned-chart/totals-earned-chart.js - About 2 hrs to fix

          Function loadData has 58 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  self.loadData = function ( data, timestamp ) {
                      var runningTotal = 0,
                          currentDate = new Date(),
                          lastData,
                          days = self.campaign().getLengthInDays(),
          Severity: Major
          Found in src/components/widgets/totals-earned-chart/totals-earned-chart.js - About 2 hrs to fix

            Function reloadData has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    self.reloadData = function ( automatic ) {
                        // FIXME: use some common filter logic
                        var qs = '$filter=' + self.campaign().getDateFilter() + ' and ' +
                                'Amount lt \'' + self.majorDonationCutoff() + '\'',
                            interval = 500000,
            Severity: Minor
            Found in src/components/widgets/totals-earned-chart/totals-earned-chart.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      self.disposables.push( self.majorDonationCutoff.subscribe( function () {
                          self.config.majorDonationCutoff = self.majorDonationCutoff();
                          self.logStateChange();
                          self.reloadData();
                      } ) );
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 110..114

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                      value: function ( value, ratio, id ) {
                                          var display;
                                          if ( id === 'Daily Total' ) {
                                              display = numeral( value ).format( '$0,0' );
                                          } else {
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 334..342

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      self.disposables.push( self.includeEndowment.subscribe( function () {
                          self.config.includeEndowment = self.includeEndowment();
                          self.logStateChange();
                          self.reloadData();
                      } ) );
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 116..120

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                      value: function ( value, ratio, id ) {
                                          var display;
                                          if ( id === 'Hourly Total' ) {
                                              display = numeral( value ).format( '$0,0' );
                                          } else {
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 403..411

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          new Campaign( {
                              name: '2019',
                              startDate: Date.UTC( 2019, 9, 1 ),
                              endDate: Date.UTC( 2020, 0, 1 ),
                              target: 59400000
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 40..45
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 53..58
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 59..64

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          new Campaign( {
                              name: '2017',
                              startDate: Date.UTC( 2017, 9, 2 ),
                              endDate: Date.UTC( 2018, 0, 1 ),
                              target: 51000000
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 40..45
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 47..52
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 53..58

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          new Campaign( {
                              name: '2020',
                              startDate: Date.UTC( 2019, 9, 1 ),
                              endDate: Date.UTC( 2020, 0, 1 ),
                              target: 60000000
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 47..52
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 53..58
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 59..64

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          new Campaign( {
                              name: '2018',
                              startDate: Date.UTC( 2018, 9, 1 ),
                              endDate: Date.UTC( 2019, 0, 1 ),
                              target: 57500000
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 40..45
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 47..52
              src/components/widgets/totals-earned-chart/totals-earned-chart.js on lines 59..64

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status