Sign upLogin

wildalmighty/BattleShips

View on GitHub
Star

Showing 5 of 7 total issues

Method fireAction has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function fireAction() {

        $row = filter_input(INPUT_POST, 'row');
        $col = filter_input(INPUT_POST, 'col');
Severity: Minor
Found in app/Controller/GameWEB.php - About 1 hr to fix

    Function fire has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function fire($row, $col) {
        $ship = $this->board->fire($row, $col);
        if ($ship) {
            if ($ship->isSunk()) {
                if ($this->board->isCleared()) {
    Severity: Minor
    Found in app/Controller/Game.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return "Error! Try again?";
    Severity: Major
    Found in app/Controller/Game.php - About 30 mins to fix

      Function hasCollision has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function hasCollision(Array $points) {
        foreach ($points as $coordinates) {
            if ($coordinates[0] > self::ROWS || $coordinates[1] > self::COLS) {
                return true;
            }
      Severity: Minor
      Found in app/Model/Board.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getGridRevealed has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getGridRevealed() {
        $grid = $this->getGrid();
        foreach ($grid as $rowNum => $cols) {
            foreach ($cols as $colNum => $position) {
                if ($this->hasShip(array($rowNum, $colNum))) {
      Severity: Minor
      Found in app/Model/Board.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language