wkdhkr/dedupper

View on GitHub
src/services/amazon/ACDService.js

Summary

Maintainability
F
3 days
Test Coverage

File ACDService.js has 528 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// @flow
// import sleep from "await-sleep";
import pLimit from "p-limit";
import { wrapper } from "axios-cookiejar-support";
import FormData from "form-data";
Severity: Major
Found in src/services/amazon/ACDService.js - About 1 day to fix

    ACDService has 28 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export default class ACDService {
      lock: (name: string) => any = (name: string) => LockHelper.lockProcess(name);
    
      unlock: (name: string) => Promise<void> = (name: string) =>
        LockHelper.unlockProcess(name);
    Severity: Minor
    Found in src/services/amazon/ACDService.js - About 3 hrs to fix

      Function result has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            const result = await limitForPrepareFolder(async () => {
              const directories = folderPath.replace(/(^\/|\/$)/g, "").split("/");
              const fullPathDirectories = directories.map((d, i) => [
                Array.from(Array(i + 1).keys()).map(j => directories[j]),
                d
      Severity: Minor
      Found in src/services/amazon/ACDService.js - About 1 hr to fix

        Function escapeForQuery has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const escapeForQuery = (str: string) => {
          let escapedStr = str;
          [
            " ",
            "+",
        Severity: Minor
        Found in src/services/amazon/ACDService.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              return new Promise((resolve, reject) => {
                form.pipe(
                  concat({ encoding: "buffer" }, async data => {
                    try {
                      const res = await axios.put(
          Severity: Major
          Found in src/services/amazon/ACDService.js and 1 other location - About 6 hrs to fix
          src/services/amazon/ACDService.js on lines 203..224

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 162.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              return new Promise((resolve, reject) => {
                form.pipe(
                  concat({ encoding: "buffer" }, async data => {
                    try {
                      const res = await axios.post(
          Severity: Major
          Found in src/services/amazon/ACDService.js and 1 other location - About 6 hrs to fix
          src/services/amazon/ACDService.js on lines 304..325

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 162.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              try {
                this.appConfig = JSON.parse(
                  await fs.readFile(this.configFilePath, "utf-8")
                );
              } catch (e) {
          Severity: Major
          Found in src/services/amazon/ACDService.js and 2 other locations - About 45 mins to fix
          src/services/amazon/ACDService.js on lines 595..601
          src/services/amazon/ACDService.js on lines 610..616

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                try {
                  this.cookies = JSON.parse(
                    await fs.readFile(this.cookieFilePath, "utf-8")
                  );
                } catch (e) {
          Severity: Major
          Found in src/services/amazon/ACDService.js and 2 other locations - About 45 mins to fix
          src/services/amazon/ACDService.js on lines 603..609
          src/services/amazon/ACDService.js on lines 610..616

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              try {
                this.accessTokenInfo = JSON.parse(
                  await fs.readFile(this.tokenFilePath, "utf-8")
                );
              } catch (e) {
          Severity: Major
          Found in src/services/amazon/ACDService.js and 2 other locations - About 45 mins to fix
          src/services/amazon/ACDService.js on lines 595..601
          src/services/amazon/ACDService.js on lines 603..609

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status