Sign upLogin

wkdhkr/dedupper

View on GitHub
Star
src/services/db/ChannelDbService.js

Summary

Maintainability
F
3 days
Test Coverage

Function deleteById has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  deleteById($id: string): Promise<?any> {
    return new Promise((resolve, reject) => {
      if (!$id) {
        resolve();
        return;
Severity: Minor
Found in src/services/db/ChannelDbService.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      deleteById($id: string): Promise<?any> {
    return new Promise((resolve, reject) => {
      if (!$id) {
        resolve();
        return;
    Severity: Major
    Found in src/services/db/ChannelDbService.js and 1 other location - About 1 day to fix
    src/services/db/TagDbService.js on lines 36..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 253.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      queryById($id: string): Promise<?any> {
    return new Promise((resolve, reject) => {
      if (!$id) {
        resolve();
        return;
    Severity: Major
    Found in src/services/db/ChannelDbService.js and 1 other location - About 1 day to fix
    src/services/db/TagDbService.js on lines 70..91

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 199.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      all: () => Promise<Array<ChannelRow>> = (): Promise<ChannelRow[]> =>
    new Promise((resolve, reject) => {
      const db = this.ss.spawn<ChannelRow>(
        this.ss.detectDbFilePath(TYPE_CHANNEL)
      );
    Severity: Major
    Found in src/services/db/ChannelDbService.js and 1 other location - About 7 hrs to fix
    src/services/db/DbService.js on lines 161..185

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 178.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

      constructor(config: Config) {
    this.log = config.getLogger(this);
    this.config = config;
    this.ss = new SQLiteService(config);
  }
    Severity: Major
    Found in src/services/db/ChannelDbService.js and 8 other locations - About 1 hr to fix
    src/services/db/FacePPDbService.js on lines 26..30
    src/services/db/NsfwJsDbService.js on lines 18..22
    src/services/db/ProcessStateDbService.js on lines 19..23
    src/services/db/TagDbService.js on lines 16..20
    src/services/deepLearning/NsfwJsService.js on lines 29..33
    src/services/fs/AttributeService.js on lines 31..35
    src/services/fs/contents/PHashService.js on lines 19..23
    src/services/judgment/DeepLearningLogic.js on lines 17..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      async init() {
    const db = this.ss.spawn(this.ss.detectDbFilePath(TYPE_CHANNEL));
    await this.prepareTable(db);
  }
    Severity: Major
    Found in src/services/db/ChannelDbService.js and 2 other locations - About 50 mins to fix
    src/services/db/ProcessStateDbService.js on lines 25..28
    src/services/db/TagDbService.js on lines 22..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status