wkdhkr/dedupper

View on GitHub
src/services/db/DbService.js

Summary

Maintainability
F
3 days
Test Coverage

File DbService.js has 548 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// @flow
import fs from "fs-extra";
import path from "path";

import typeof { Logger } from "log4js";
Severity: Major
Found in src/services/db/DbService.js - About 1 day to fix

    Function queryByPHash has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      queryByPHash({
        p_hash: pHash,
        d_hash: dHash,
        from_path: fromPath,
        type,
    Severity: Major
    Found in src/services/db/DbService.js - About 3 hrs to fix

      Function deleteByHash has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        deleteByHash({ hash: $hash, type }: FileInfo): Promise<?HashRow> {
          return new Promise((resolve, reject) => {
            if (!$hash) {
              resolve();
              return;
      Severity: Minor
      Found in src/services/db/DbService.js - About 1 hr to fix

        Function queryByValue has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          queryByValue(
            column: string,
            $value: number | string,
            type: ClassifyType
          ): Promise<HashRow[]> {
        Severity: Minor
        Found in src/services/db/DbService.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

              return false;
          Severity: Major
          Found in src/services/db/DbService.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              all: (type: ClassifyType) => Promise<Array<HashRow>> = (
                type: ClassifyType
              ): Promise<HashRow[]> =>
                new Promise((resolve, reject) => {
                  const db = this.ss.spawn<HashRow>(this.ss.detectDbFilePath(type));
            Severity: Major
            Found in src/services/db/DbService.js and 1 other location - About 7 hrs to fix
            src/services/db/ChannelDbService.js on lines 73..97

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 178.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              static infoToRow: FileInfo => HashRow = ({
                hash,
                p_hash, // eslint-disable-line camelcase
                d_hash, // eslint-disable-line camelcase
                width,
            Severity: Major
            Found in src/services/db/DbService.js and 1 other location - About 2 hrs to fix
            src/services/db/DbService.js on lines 366..380

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 83.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                {
                  hash,
                  p_hash, // eslint-disable-line camelcase
                  d_hash, // eslint-disable-line camelcase
                  width,
            Severity: Major
            Found in src/services/db/DbService.js and 1 other location - About 2 hrs to fix
            src/services/db/DbService.js on lines 335..349

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 83.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      const row = {
                        $hash,
                        $pHash,
                        $dHash,
                        $width,
            Severity: Major
            Found in src/services/db/DbService.js and 1 other location - About 1 hr to fix
            src/services/db/DbService.js on lines 484..498

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      const {
                        hash: $hash,
                        p_hash: $pHash,
                        d_hash: $dHash,
                        width: $width,
            Severity: Major
            Found in src/services/db/DbService.js and 1 other location - About 1 hr to fix
            src/services/db/DbService.js on lines 501..515

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status