wkdhkr/dedupper

View on GitHub
src/services/db/NsfwJsDbService.js

Summary

Maintainability
F
4 days
Test Coverage

File NsfwJsDbService.js has 291 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// @flow
import typeof { Logger } from "log4js";
import { STATE_ACCEPTED, STATE_KEEPING } from "../../types/FileStates";
import SQLiteService from "./SQLiteService";
import { TYPE_IMAGE } from "../../types/ClassifyTypes";
Severity: Minor
Found in src/services/db/NsfwJsDbService.js - About 3 hrs to fix

    Function queryByValue has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      queryByValue(
        column: string,
        $value: number | string
      ): Promise<NsfwJsHashRow[]> {
        return new Promise((resolve, reject) => {
    Severity: Minor
    Found in src/services/db/NsfwJsDbService.js - About 1 hr to fix

      Function deleteByHash has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        deleteByHash({ hash: $hash }: FileInfo): Promise<?NsfwJsHashRow> {
          return new Promise((resolve, reject) => {
            if (!$hash) {
              resolve();
              return;
      Severity: Minor
      Found in src/services/db/NsfwJsDbService.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          deleteByHash({ hash: $hash }: FileInfo): Promise<?NsfwJsHashRow> {
            return new Promise((resolve, reject) => {
              if (!$hash) {
                resolve();
                return;
        Severity: Major
        Found in src/services/db/NsfwJsDbService.js and 1 other location - About 1 day to fix
        src/services/db/FacePPDbService.js on lines 178..211

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 280.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              db.serialize(async () => {
                try {
                  await this.prepareTable(db);
                  db.all(
                    `select * from ${this.config.deepLearningConfig.nsfwJsDbTableName}`,
        Severity: Major
        Found in src/services/db/NsfwJsDbService.js and 1 other location - About 4 hrs to fix
        src/services/db/FacePPDbService.js on lines 244..262

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 132.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                      db.run(
                        `insert${replaceStatement} into ${this.config.deepLearningConfig.nsfwJsDbTableName} (${columns}) values (${values})`,
                        row,
                        err => {
                          if (err) {
        Severity: Major
        Found in src/services/db/NsfwJsDbService.js and 1 other location - About 3 hrs to fix
        src/services/db/FacePPDbService.js on lines 877..891

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 110.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          prepareTable: (db: Database<NsfwJsHashRow>) => Promise<void> = async (
            db: Database<NsfwJsHashRow>
          ) =>
            this.ss.prepareTable(
              db,
        Severity: Major
        Found in src/services/db/NsfwJsDbService.js and 1 other location - About 2 hrs to fix
        src/services/db/FacePPDbService.js on lines 50..57

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 85.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  (err, rows: NsfwJsHashRow[]) => {
                    db.close();
                    if (!this.ss.handleEachError(db, err, reject)) {
                      return;
                    }
        Severity: Major
        Found in src/services/db/NsfwJsDbService.js and 1 other location - About 1 hr to fix
        src/services/db/ProcessStateDbService.js on lines 84..90

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 9 locations. Consider refactoring.
        Open

          constructor(config: Config) {
            this.log = config.getLogger(this);
            this.config = config;
            this.ss = new SQLiteService(config);
          }
        Severity: Major
        Found in src/services/db/NsfwJsDbService.js and 8 other locations - About 1 hr to fix
        src/services/db/ChannelDbService.js on lines 24..28
        src/services/db/FacePPDbService.js on lines 26..30
        src/services/db/ProcessStateDbService.js on lines 19..23
        src/services/db/TagDbService.js on lines 16..20
        src/services/deepLearning/NsfwJsService.js on lines 29..33
        src/services/fs/AttributeService.js on lines 31..35
        src/services/fs/contents/PHashService.js on lines 19..23
        src/services/judgment/DeepLearningLogic.js on lines 17..21

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    (err, row: NsfwJsHashRow) => {
                      db.close();
                      this.ss.handleEachError<NsfwJsHashRow>(
                        db,
                        err,
        Severity: Minor
        Found in src/services/db/NsfwJsDbService.js and 1 other location - About 40 mins to fix
        src/services/db/ProcessStateDbService.js on lines 110..119

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status