wkdhkr/dedupper

View on GitHub
src/services/db/TagDbService.js

Summary

Maintainability
F
4 days
Test Coverage

Function deleteByHash has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  deleteByHash($hash: string): Promise<?any> {
    return new Promise((resolve, reject) => {
      if (!$hash) {
        resolve();
        return;
Severity: Minor
Found in src/services/db/TagDbService.js - About 1 hr to fix

    Function queryByValue has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      queryByValue(column: string, $value: number | string): Promise<any[]> {
        return new Promise((resolve, reject) => {
          const db = this.ss.spawn<any>(this.ss.detectDbFilePath(TYPE_IMAGE));
          const rows = [];
          db.serialize(async () => {
    Severity: Minor
    Found in src/services/db/TagDbService.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        deleteByHash($hash: string): Promise<?any> {
          return new Promise((resolve, reject) => {
            if (!$hash) {
              resolve();
              return;
      Severity: Major
      Found in src/services/db/TagDbService.js and 1 other location - About 1 day to fix
      src/services/db/ChannelDbService.js on lines 39..71

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 253.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        queryByHash($hash: string): Promise<?any> {
          return new Promise((resolve, reject) => {
            if (!$hash) {
              resolve();
              return;
      Severity: Major
      Found in src/services/db/TagDbService.js and 1 other location - About 1 day to fix
      src/services/db/ChannelDbService.js on lines 99..120

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 199.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                    db.run(
                      `insert${replaceStatement} into ${this.config.tagDbName} (${columns}) values (${values})`,
                      this.createRowBind(row),
                      err => {
                        if (err) {
      Severity: Major
      Found in src/services/db/TagDbService.js and 1 other location - About 3 hrs to fix
      src/services/db/ProcessStateDbService.js on lines 258..272

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        createRowBind: (row: any) => { ... } = (row: Object) => {
          const newRow = {};
      
          Object.keys(row).forEach(key => {
            newRow[`$${key}`] = row[key] !== undefined ? row[key] : null;
      Severity: Major
      Found in src/services/db/TagDbService.js and 1 other location - About 2 hrs to fix
      src/services/db/ProcessStateDbService.js on lines 136..144

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 88.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                    const columns = [
                      "hash",
                      ...Array.from({ length: this.config.tagDbLength }).map(
                        (n, i) => `t${i + 1}`
                      )
      Severity: Major
      Found in src/services/db/TagDbService.js and 1 other location - About 1 hr to fix
      src/services/db/TagDbService.js on lines 188..193

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                    const values = [
                      "$hash",
                      ...Array.from({ length: this.config.tagDbLength }).map(
                        (n, i) => `$t${i + 1}`
                      )
      Severity: Major
      Found in src/services/db/TagDbService.js and 1 other location - About 1 hr to fix
      src/services/db/TagDbService.js on lines 182..187

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

        constructor(config: Config) {
          this.log = config.getLogger(this);
          this.config = config;
          this.ss = new SQLiteService(config);
        }
      Severity: Major
      Found in src/services/db/TagDbService.js and 8 other locations - About 1 hr to fix
      src/services/db/ChannelDbService.js on lines 24..28
      src/services/db/FacePPDbService.js on lines 26..30
      src/services/db/NsfwJsDbService.js on lines 18..22
      src/services/db/ProcessStateDbService.js on lines 19..23
      src/services/deepLearning/NsfwJsService.js on lines 29..33
      src/services/fs/AttributeService.js on lines 31..35
      src/services/fs/contents/PHashService.js on lines 19..23
      src/services/judgment/DeepLearningLogic.js on lines 17..21

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        async init() {
          const db = this.ss.spawn(this.ss.detectDbFilePath(TYPE_IMAGE));
          await this.prepareTable(db);
        }
      Severity: Major
      Found in src/services/db/TagDbService.js and 2 other locations - About 50 mins to fix
      src/services/db/ChannelDbService.js on lines 30..33
      src/services/db/ProcessStateDbService.js on lines 25..28

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status