Similar blocks of code found in 2 locations. Consider refactoring. Open
class MoyskladApiError extends MoyskladRequestError {
constructor(errors, response) {
const error = errors[0]
/* c8 ignore next */
const message = error.error + (error.moreInfo ? ` (${error.moreInfo})` : '')
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 174.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
class MoyskladUnexpectedRedirectError extends MoyskladRequestError {
constructor(response) {
super(
`Неожиданное перенаправление запроса с кодом ${response.status}` +
' (см. подробнее https://github.com/wmakeev/moysklad#moyskladunexpectedredirecterror)',
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 124.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
class MoyskladError extends Error {
constructor(message, ...args) {
super(message, ...args)
this.name = this.constructor.name
/* c8 ignore else */
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 80.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
class MoyskladRequestError extends MoyskladError {
constructor(message, response) {
super(message)
if (response) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 77.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Replace '·(см.·подробнее·https://github.com/wmakeev/moysklad#moyskladunexpectedredirecterror)'
with "·(см.·подробнее·https://github.com/wmakeev/moysklad#moyskladunexpectedredirecterror)"
Open
' (см. подробнее https://github.com/wmakeev/moysklad#moyskladunexpectedredirecterror)',
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
super(message, ...args)
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
this.code = error.code
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
if (error.line != null) this.line = error.line
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
this.url = response.url
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
if (error.column != null) this.column = error.column
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
super(message)
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
this.moreInfo = error.moreInfo
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
super(errors, response)
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
this.url = response.url
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
this.name = this.constructor.name
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
this.location = location
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
this.errors = errors
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
this.statusText = response.statusText
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
const error = errors[0]
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Replace ·error.error·+·(error.moreInfo·?·
·(${error.moreInfo})·:·'')
with ⏎······error.error·+·(error.moreInfo·?·
·(${error.moreInfo})·:·"");
Open
const message = error.error + (error.moreInfo ? ` (${error.moreInfo})` : '')
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
Error.captureStackTrace(this, this.constructor)
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Replace 'use·strict'
with "use·strict";
Open
'use strict'
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
this.status = response.status
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
super(message, response)
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
this.statusText = response.statusText
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
)
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Replace 'location')
with "location");
Open
const location = response.headers.get('location')
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
this.status = response.status
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
this.errorsIndexes = errorsIndexes
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/
Insert ;
Open
}
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/