wmakeev/moysklad

View on GitHub
src/getEnvVar.js

Summary

Maintainability
A
45 mins
Test Coverage
A
100%

Function getEnvVar has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

function getEnvVar(key, defaultValue) {
  if (typeof process !== 'undefined' && process.env && process.env[key]) {
    return process.env[key]
  } else if (typeof window !== 'undefined' && window[key]) {
    return window[key]
Severity: Minor
Found in src/getEnvVar.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Replace 'use·strict' with "use·strict";
Open

'use strict'
Severity: Minor
Found in src/getEnvVar.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Replace 'undefined' with "undefined"
Open

  } else if (typeof window !== 'undefined' && window[key]) {
Severity: Minor
Found in src/getEnvVar.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Insert ;
Open

    return window[key]
Severity: Minor
Found in src/getEnvVar.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Insert ;
Open

module.exports = getEnvVar
Severity: Minor
Found in src/getEnvVar.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Insert ;
Open

    return global[key]
Severity: Minor
Found in src/getEnvVar.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Insert ;
Open

    return process.env[key]
Severity: Minor
Found in src/getEnvVar.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Replace 'undefined' with "undefined"
Open

  } else if (typeof global !== 'undefined' && global[key]) {
Severity: Minor
Found in src/getEnvVar.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Replace 'undefined' with "undefined"
Open

  if (typeof process !== 'undefined' && process.env && process.env[key]) {
Severity: Minor
Found in src/getEnvVar.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Insert ;
Open

    return defaultValue !== undefined ? defaultValue : null
Severity: Minor
Found in src/getEnvVar.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There are no issues that match your filters.

Category
Status